Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New PDF editor #3096

Closed
reckart opened this issue Jun 5, 2022 · 0 comments
Closed

New PDF editor #3096

reckart opened this issue Jun 5, 2022 · 0 comments
Assignees
@reckart
Labels
⭐️ Enhancement New feature or request Module: PDF editor
Projects
Kanban
Milestone
24.0

Comments

@reckart
Copy link
Member

reckart commented Jun 5, 2022

Describe the refactoring action
The PDF editor is in for a major refactoring.

Expected benefit
Better maintainability, less bugs.
@reckart reckart self-assigned this Jun 5, 2022
@reckart reckart added this to 🔖 To do in Kanban via automation Jun 5, 2022
reckart added a commit that referenced this issue Jun 5, 2022
@reckart
#3096 - New PDF editor
9647dcc 
- Add new PDF module
- Reimplement the glyph position extraction code directly by adapting the original pdfbox code
@reckart reckart added the ⭐️ Enhancement New feature or request label Jun 7, 2022
reckart added a commit that referenced this issue Jun 11, 2022
@reckart
#3096 - New PDF editor
cf9100e 
- Fix dependency
reckart added a commit that referenced this issue Jun 12, 2022
@reckart
#3096 - New PDF editor
a8b7c7b 
- Add new module to eclipse settings shell script
reckart added a commit that referenced this issue Jun 12, 2022
@reckart
#3096 - New PDF editor
b6d0f1a 
- Adjust representation of visual model to be more space efficient
- Improved test
- Added UIMA types to represent visual model in the CAS
- Added UIMA reader component
reckart added a commit that referenced this issue Jun 13, 2022
@reckart
#3096 - New PDF editor
e586b58 
- Fix test for file with has rotated page and rotated text
reckart added a commit that referenced this issue Jun 15, 2022
@reckart
#3096 - New PDF editor
dce92b4 
- Fix dependencies
- Reduce test logging
reckart added a commit that referenced this issue Jun 16, 2022
@reckart
#3096 - New PDF editor
5b1a1b5 
- Update eslint settings
reckart added a commit that referenced this issue Jun 16, 2022
@reckart
#3096 - New PDF editor
9f548e2 
- Fix typo
- Remove unused code
- Remove commented-out code
reckart added a commit that referenced this issue Jun 22, 2022
@reckart
#3096 - New PDF editor
fd771db 
- Reduce memory footprint of visual model in CAS
reckart added a commit that referenced this issue Jun 22, 2022
@reckart
#3096 - New PDF editor
c65e0df 
- Rename PdfLine to PdfChunk because it's not really a line
- Added a new test
reckart added a commit that referenced this issue Jun 22, 2022
@reckart
#3096 - New PDF editor
7b961a0 
- Fix test
reckart added a commit that referenced this issue Jun 23, 2022
@reckart
#3096 - New PDF editor
762f236 
- Stop spamming log during test
reckart added a commit that referenced this issue Jun 23, 2022
@reckart
#3096 - New PDF editor
ea3d097 
- Fix dependencies
reckart added a commit that referenced this issue Jun 24, 2022
@reckart
#3096 - New PDF editor
5903684 
- Fix dependencies
reckart added a commit that referenced this issue Jun 24, 2022
@reckart
#3096 - New PDF editor
6837f21 
- Fix dependencies
reckart added a commit that referenced this issue Jun 25, 2022
@reckart
#3096 - New PDF editor
a7c6a18 
- Fix field name
reckart added a commit that referenced this issue Jun 27, 2022
@reckart
#3096 - New PDF editor
b35795d 
- Make text extraction from PDF work more reliably in both file-order-extraction and visual-order-extraction modes
reckart added a commit that referenced this issue Jun 27, 2022
@reckart
#3096 - New PDF editor
4ec7b2b 
- Fix assert
reckart added a commit that referenced this issue Jun 27, 2022
@reckart
#3096 - New PDF editor
9dbb1a6 
- Frontend code for the new PDF editor (disabled by default)
- Format support plugin (disabled by default)
reckart added a commit that referenced this issue Jun 28, 2022
@reckart
#3096 - New PDF editor
08fed92 
- Fix test
- Fix dependency
reckart added a commit that referenced this issue Jun 28, 2022
@reckart
#3096 - New PDF editor
3227802 
- Fix dependency
@reckart reckart added this to the 24.0 milestone Jul 5, 2022
reckart added a commit that referenced this issue Jul 9, 2022
@reckart
#3096 - New PDF editor
2ab8ff9 
- Fix (or at least improve) support for bidi (RTL/LTR) text
reckart added a commit that referenced this issue Jul 9, 2022
@reckart
#3096 - New PDF editor
ec61742 
- Fix dependency
- Re-use existing string instead of allocating a new one
reckart added a commit that referenced this issue Jul 9, 2022
@reckart
Merge pull request #3097 from inception-project/feature/3096-New-PDF-…
23cdd7f 
…editor

#3096 - New PDF editor
@reckart reckart closed this as completed Jul 9, 2022
Kanban automation moved this from 🔖 To do to 🍹 Done Jul 9, 2022
reckart added a commit that referenced this issue Jul 9, 2022
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
03281a0 
* main: (24 commits)
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3173 - Cannot open annotation when editor is pre-configured
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3096 - New PDF editor
  ...
@reckart reckart reopened this Jul 17, 2022
Kanban automation moved this from 🍹 Done to 🏃‍♀️ In progress Jul 17, 2022
reckart added a commit that referenced this issue Jul 17, 2022
@reckart
#3096 - New PDF editor
d2e5ae3 
- Also render annotations on the page before and after the current page if possible
- Slightly change the rendering style for annotations to only a border below
- Pointer cursor over knobs
reckart added a commit that referenced this issue Jul 17, 2022
@reckart
#3096 - New PDF editor
5aec9d1 
- Remove opacity setting from annotation highlights and rely on the semitransparent highlight background
- The knob should always be halt-transparent
- Add selection highlight to the currently selected annotation
- Improve support for annotation/text markers
reckart added a commit that referenced this issue Jul 17, 2022
@reckart
#3096 - New PDF editor
b31069d 
- Removed unused code for client-side selection management
- Add selection highlight to the knob of the selected annotation
reckart added a commit that referenced this issue Jul 17, 2022
@reckart
Merge pull request #3196 from inception-project/feature/3096-New-PDF-…
16f1f6f 
…editor

#3096 - New PDF editor
@reckart reckart closed this as completed Jul 17, 2022
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Jul 17, 2022
@reckart reckart mentioned this issue Jul 18, 2022
Closed
reckart added a commit that referenced this issue Jul 19, 2022
@reckart
#3096 - New PDF editor
5ecbda7 
- Rename old PDF editor and format to "PDF (legacy)" in the UI
- The new one is now "PDF" and is enabled by default
reckart added a commit that referenced this issue Jul 19, 2022
@reckart
Merge pull request #3199 from inception-project/feature/3096-New-PDF-…
2ef0bc9 
…editor

#3096 - New PDF editor
reckart added a commit that referenced this issue Jul 19, 2022
@reckart
Merge branch 'main' into bugfix/3201-Can-still-accept-reject-suggesti…
d4aecbf 
…ons-on-closed-document

* main:
  #3201 - Can still accept/reject suggestions on closed document
  #3096 - New PDF editor
reckart added a commit that referenced this issue Jul 19, 2022
@reckart
Merge branch 'main' into 3194-Jumping-to-location-may-not-bring-targe…
75a8bea 
…t-into-view

* main:
  #3201 - Can still accept/reject suggestions on closed document
  #1606 - Search result list jumps back to top
  #3096 - New PDF editor
reckart added a commit that referenced this issue Aug 10, 2022
@reckart
#3096 - New PDF editor
8f8fc8d 
- Added documentation
- Marked old documentatin as legacy
- Switch to auto-configuration for PDF module
- Disable legacy PDF format support by default (editor remains enabled so existing legacy PDF files can still be edited)
reckart added a commit that referenced this issue Aug 10, 2022
@reckart
#3096 - New PDF editor
d526b1f 
- Fix dependencies
- Fix formatting
reckart added a commit that referenced this issue Aug 10, 2022
@reckart
Merge pull request #3283 from inception-project/feature/3096-New-PDF-…
19351a0 
…editor

#3096 - New PDF editor
reckart added a commit that referenced this issue Aug 10, 2022
@reckart
Merge branch 'release/24.x'
0389466 
* release/24.x:
  #3096 - New PDF editor
  #3096 - New PDF editor
  #3281 - Support the new UIMA JSON CAS format
  #3276 - Harmonize TS builds
  #3281 - Support the new UIMA JSON CAS format
  #3281 - Support the new UIMA JSON CAS format
  #3279 - Exception in Recommender Service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: PDF editor
Projects
Kanban
  
🍹 Done
Milestone
24.0
Development

No branches or pull requests
1 participant
@reckart