Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to merge via curation siderbar if username contains "." #2077

Closed
reckart opened this issue Mar 12, 2021 · 0 comments
Closed

Unable to merge via curation siderbar if username contains "." #2077

reckart opened this issue Mar 12, 2021 · 0 comments
Assignees
Labels
🐛Bug Something isn't working Module: Curation
Projects
Milestone

Comments

@reckart
Copy link
Member

reckart commented Mar 12, 2021

Describe the bug
If the username of an annotator contains special characters, their annotation cannot be merged anymore.

The problem is the VID encoding used by the curation sidebar as well as the regular expression used to parse it. The regex does not consider all characters possible in a user name. The VID encoding does neither escape the username or use a character that cannot occur in a username as a separator between username and payload. It uses ":" as a separator which can occur in a username.

To Reproduce
Steps to reproduce the behavior:

  1. Create a user "john.smith"
  2. Make annotations with the user
  3. Open the annotation page and the curation sidebar
  4. Try to merge an annotation from user "john.smith"

Expected behavior
Should just work.

Please complete the following information:

  • Version and build ID: 0.18.3
@reckart reckart added 🐛Bug Something isn't working Module: Curation labels Mar 12, 2021
@reckart reckart added this to the 0.18.4 milestone Mar 12, 2021
@reckart reckart self-assigned this Mar 12, 2021
@reckart reckart added this to 🔖 To do in Kanban via automation Mar 12, 2021
reckart added a commit that referenced this issue Mar 12, 2021
- Fix issue by adapting CurationVID parsing / generation
- Use ! character to separate username from payload because ! is not allowed in usernames
reckart added a commit that referenced this issue Mar 12, 2021
- Fix issue by adapting CurationVID parsing / generation
- Use ! character to separate username from payload because ! is not allowed in usernames
reckart added a commit that referenced this issue Mar 12, 2021
…-merge-via-curation-siderbar-if-username-contains-DOT-0_18_x

#2077 - Unable to merge via curation siderbar if username contains "."
reckart added a commit that referenced this issue Mar 12, 2021
…-merge-via-curation-siderbar-if-username-contains-DOT

#2077 - Unable to merge via curation siderbar if username contains "."
@reckart reckart closed this as completed Mar 12, 2021
Kanban automation moved this from 🔖 To do to 🍹 Done Mar 12, 2021
reckart added a commit that referenced this issue Mar 12, 2021
…-broken

* master:
  #2077 - Unable to merge via curation siderbar if username contains "."
  #1895 - Merging relations and slots is broken
  #2077 - Unable to merge via curation siderbar if username contains "."
  No issue. Depend on snapshot version of WebAnno.
  #1893 - Deleting a span to which relations connect leaves dangling relations
  #2075 - Deleting a span to which relations connect leaves dangling relations
  #1893 - Deleting a span to which relations connect leaves dangling relations
  #2075 - Deleting a span to which relations connect leaves dangling relations
@reckart reckart modified the milestones: 0.18.4, 0.19.0 Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Curation
Projects
Kanban
  
🍹 Done
Development

No branches or pull requests

1 participant