Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2077 - Unable to merge via curation siderbar if username contains "." #2081

Conversation

reckart
Copy link
Member

@reckart reckart commented Mar 12, 2021

What's in the PR

  • Fix issue by adapting CurationVID parsing / generation
  • Use ! character to separate username from payload because ! is not allowed in usernames

How to test manually

  • See issue description

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Fix issue by adapting CurationVID parsing / generation
- Use ! character to separate username from payload because ! is not allowed in usernames
@reckart reckart added 🐛Bug Something isn't working Module: Curation labels Mar 12, 2021
@reckart reckart added this to the 0.18.4 milestone Mar 12, 2021
@reckart reckart self-assigned this Mar 12, 2021
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Mar 12, 2021
@reckart reckart merged commit 83f87f9 into 0.18.x Mar 12, 2021
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Mar 12, 2021
@reckart reckart deleted the bugfix/2077-Unable-to-merge-via-curation-siderbar-if-username-contains-DOT-0_18_x branch March 12, 2021 23:24
@reckart reckart modified the milestones: 0.18.4, 0.19.0 Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Curation
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant