Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New export page does not work over HTTPS #2689

Closed
reckart opened this issue Nov 7, 2021 · 2 comments
Closed

New export page does not work over HTTPS #2689

reckart opened this issue Nov 7, 2021 · 2 comments
Assignees
@jcklie @reckart
Labels
🐛Bug Something isn't working Module: Project Settings
Projects
Kanban
Milestone
22.0

Comments

@reckart
Copy link
Member

reckart commented Nov 7, 2021

Describe the bug
The new export page uses unencrypted WebSocket even when running over HTTPS which means that the browser will actually block the entire active downloads component.

To Reproduce
Steps to reproduce the behavior:

  1. Log in to an INCEpTION instance that is using HTTPS
  2. Go to the exports page of a project
  3. Note that the right sidebar is missing
  4. Check the browser console messages

Expected behavior
Optimally, INCEpTION should detect when it is being used over HTTPS and in that case offer a WSS URL to the browser.

Screenshots

Mixed Content: The page at 'https://.../inception/p/x001-demo/settings/details?4' was loaded over HTTPS, but attempted to connect to the insecure WebSocket endpoint 'ws://...:443/inception/ws-endpoint'. This request has been blocked; this endpoint must be available over WSS.

Please complete the following information:

  • Version and build ID: 22.0-SNAPSHOT
@reckart reckart added 🐛Bug Something isn't working Module: Project Settings labels Nov 7, 2021
@reckart reckart added this to the 22.0 milestone Nov 7, 2021
@reckart reckart added this to 🔖 To do in Kanban via automation Nov 7, 2021
jcklie added a commit that referenced this issue Nov 9, 2021
@jcklie
#2689 - New export page does not work over HTTPS
66bf7e1 
- Use wss for HTTPS
reckart added a commit that referenced this issue Dec 5, 2021
@reckart
Merge pull request #2690 from inception-project/bugfix/2689-ws-https
a0294fe 
#2689 - New export page does not work over HTTPS
@reckart reckart moved this from 🔖 To do to 🏃‍♀️ In progress in Kanban Dec 5, 2021
reckart added a commit that referenced this issue Dec 5, 2021
@reckart
#2689 - New export page does not work over HTTPS
68e432f 
- Change WS endpoint url to `.../ws`
- Change JS/TS code to use wss if the primary connection was made over https
- Fix permissions for cancelling a download via a WS message
- Allow loading settings from a YAML file
- Update documentation for Apache reverse proxy to use http instead of ajp because ajp does not work with websocket
- Pick up CSRF configuration from Spring Boot Wicket and inject it into the Spring Websocket STOMP endpoint as well
@reckart reckart closed this as completed Dec 12, 2021
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Dec 12, 2021
reckart added a commit that referenced this issue Dec 12, 2021
@reckart
Merge branch 'main' into feature/2443-keep-search-results-ordering
9e6cc5c 
* main: (280 commits)
  No issue. Change export task title when export is triggered via remote API.
  #2744 - YAML configuration file
  #2697 - Curation Overview list reset
  #2697 - Curation Overview list reset
  #2742 - Dependency upgrades (21.3)
  No issue. Silence WebSocketMessageBrokerStats.
  Bump log4j-core from 2.14.1 to 2.15.0 in /inception
  #2689 - New export page does not work over HTTPS
  #2233 - Allow to set Page size as Admin for a project to something higher than 5
  #2732 - Upgrade RecogitoJS and convert to DIAM AJAX
  #2732 - Upgrade RecogitoJS and convert to DIAM AJAX
  #2732 - Upgrade RecogitoJS and convert to DIAM AJAX
  #2630 - Upgrade dependencies
  No issue: Avoid possible exception if somebody manages to trigger the delete button when no annotation has been selected
  #2676 - Hide page navigation if there is only one screen full of lines
  #2673 - Hide RTL button
  #2673 - Hide RTL button
  #2673 - Hide RTL button
  #2678 - Set default annotation editor in project settings
  #2678 - Set default annotation editor in project settings
  ...

% Conflicts:
%	inception/inception-search-mtas/src/test/java/de/tudarmstadt/ukp/inception/search/index/mtas/MtasDocumentIndexTest.java
@blochs
Copy link

blochs commented Jan 13, 2022

@reckart this has reappeared in 22.1…

@reckart
Copy link
Member Author

reckart commented Jan 13, 2022

Did you update you reverse proxy settings for WebSocket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcklie jcklie

@reckart reckart

Labels
🐛Bug Something isn't working Module: Project Settings
Projects
Kanban
  
🍹 Done
Milestone
22.0
Development

No branches or pull requests
3 participants
@jcklie @reckart @blochs