Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2689 - New export page does not work over HTTPS #2690

Merged
merged 4 commits into from Dec 5, 2021
Merged

#2689 - New export page does not work over HTTPS #2690

merged 4 commits into from Dec 5, 2021

Conversation

jcklie
Copy link
Contributor

@jcklie jcklie commented Nov 9, 2021

What's in the PR

  • Use wss for HTTPS

How to test manually

  • Deploy INCEpTION behind a reverse proxy ands see that e.g. the export page works

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@jcklie jcklie added the 🐛Bug Something isn't working label Nov 9, 2021
@jcklie jcklie added this to the 22.0 milestone Nov 9, 2021
@jcklie jcklie self-assigned this Nov 9, 2021
@reckart
Copy link
Member

reckart commented Nov 16, 2021

Should it be merged?

@jcklie
Copy link
Contributor Author

jcklie commented Nov 16, 2021

I was not able to make it run with a reverse proxy yet and it misses documentation and the other places also need to be fixed.

@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Dec 5, 2021
@reckart reckart merged commit a0294fe into main Dec 5, 2021
@reckart reckart deleted the bugfix/2689-ws-https branch December 5, 2021 15:18
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jcklie jcklie

Labels
🐛Bug Something isn't working
Projects
Kanban
  
🍹 Done
Milestone
22.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcklie @reckart