Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsupported features not properly detected #2694

Closed
reckart opened this issue Nov 13, 2021 · 0 comments
Closed

Unsupported features not properly detected #2694

reckart opened this issue Nov 13, 2021 · 0 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working
Milestone
21.2

Comments

@reckart
Copy link
Member

reckart commented Nov 13, 2021

Describe the bug
The methods to list only supported features do not properly skip unsupported features (i.e. AnnotationSchemaService.listSupportedFeatures(...)) - they were not updates sind findExtension was changed to return an Optional instead of throwing an exception.

Expected behavior
Only features supported by a feature support are returned.

Please complete the following information:

  • Version and build ID: 21.1
@reckart reckart added the 🐛Bug Something isn't working label Nov 13, 2021
@reckart reckart added this to the 21.2 milestone Nov 13, 2021
reckart added a commit that referenced this issue Nov 13, 2021
@reckart
#2694 - Unsupported features not properly detected
de5215d 
- Update methods to react to empty optionals
reckart added a commit that referenced this issue Nov 13, 2021
@reckart
Merge branch 'bugfix/2694-Unsupported-features-not-properly-detected'…
f5d2ebd 
… into feature/2687-Subscribe-to-annotation-updates-via-WebSocket

* bugfix/2694-Unsupported-features-not-properly-detected:
  #2694 - Unsupported features not properly detected
reckart added a commit that referenced this issue Nov 16, 2021
@reckart
Merge pull request #2695 from inception-project/bugfix/2694-Unsupport…
5e3eead 
…ed-features-not-properly-detected

#2694 - Unsupported features not properly detected
@reckart reckart self-assigned this Nov 16, 2021
@reckart reckart closed this as completed Nov 16, 2021
reckart added a commit that referenced this issue Nov 16, 2021
@reckart
Merge branch 'release/21.x'
f371998 
* release/21.x:
  #2694 - Unsupported features not properly detected
reckart added a commit that referenced this issue Nov 16, 2021
@reckart
Merge branch 'main' into feature/2443-keep-search-results-ordering
6edbde1 
* main:
  #2694 - Unsupported features not properly detected
  #2692 - Perseus treebank XML 2.1 not visible to annotate
reckart added a commit that referenced this issue Nov 16, 2021
@reckart
Merge branch 'main' into feature/2598-corpus-statistics-ui
c5927d2 
* main:
  No issue. Auto-formatting
  #2694 - Unsupported features not properly detected
  #2692 - Perseus treebank XML 2.1 not visible to annotate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working
Projects
Kanban
Archived in project
Milestone
21.2
Development

No branches or pull requests
1 participant
@reckart