Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up (brat) rendering code #2822

Closed
reckart opened this issue Jan 17, 2022 · 0 comments
Closed

Clean up (brat) rendering code #2822

reckart opened this issue Jan 17, 2022 · 0 comments
Assignees
@reckart
Labels
⚙️ Refactoring
Projects
Kanban
Milestone
23.0

Comments

@reckart
Copy link
Member

reckart commented Jan 17, 2022

Describe the refactoring action
Clean up (brat) rendering code.

Expected benefit
Less redundant code to maintain.
@reckart reckart added this to the 23.0 milestone Jan 17, 2022
@reckart reckart self-assigned this Jan 17, 2022
@reckart reckart added this to 🔖 To do in Kanban via automation Jan 17, 2022
reckart added a commit that referenced this issue Jan 17, 2022
@reckart
#2822 - Clean up (brat) rendering code
4280619 
- Pull code that cancels rendering if an editor was already rendered or that's already part of the AJAX target out into the AnnotationEditorBase class
- Pull error handling code into AnnotationEditorBase
- Remove collection and document information from brat
reckart added a commit that referenced this issue Jan 18, 2022
@reckart
Merge pull request #2823 from inception-project/reafactoring/2822-Cle…
07135a9 
…an-up-brat-rendering-code

#2822 - Clean up (brat) rendering code
@reckart reckart closed this as completed Feb 7, 2022
Kanban automation moved this from 🔖 To do to 🍹 Done Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⚙️ Refactoring
Projects
Kanban
  
🍹 Done
Milestone
23.0
Development

No branches or pull requests
1 participant
@reckart