Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2822 - Clean up (brat) rendering code #2823

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

reckart
Copy link
Member

@reckart reckart commented Jan 17, 2022

What's in the PR

  • Pull code that cancels rendering if an editor was already rendered or that's already part of the AJAX target out into the AnnotationEditorBase class
  • Pull error handling code into AnnotationEditorBase
  • Remove collection and document information from brat

How to test manually

  • No specific test procedure

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Pull code that cancels rendering if an editor was already rendered or that's already part of the AJAX target out into the AnnotationEditorBase class
- Pull error handling code into AnnotationEditorBase
- Remove collection and document information from brat
@reckart reckart added this to the 23.0 milestone Jan 17, 2022
@reckart reckart self-assigned this Jan 17, 2022
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Jan 17, 2022
@reckart reckart merged commit 07135a9 into main Jan 18, 2022
@reckart reckart deleted the reafactoring/2822-Clean-up-brat-rendering-code branch January 18, 2022 08:15
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Kanban
  
🍹 Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant