Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When marking a sequence in RTL it marks only the last character #2837

Closed
shaked571 opened this issue Jan 30, 2022 · 2 comments
Closed

When marking a sequence in RTL it marks only the last character #2837

shaked571 opened this issue Jan 30, 2022 · 2 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Annotation
Projects
Kanban
Milestone
22.3

Comments

@shaked571
Copy link

shaked571 commented Jan 30, 2022 •
edited

When marking a sequence in Hebrew (I guess it would happen in any RTL language) the annotation marks only the last character

To Reproduce
Steps to reproduce the behavior:

  1. Open a new project.
  2. Upload an Hebrew document
  3. Try to mark a word
  4. See only the last character being marked when all the marked text appearing in the text box in the right

Expected behavior
Marking all the marked text.

Screenshots
image

  • Version and build ID: inception-app-webapp-22.2-standalone
  • OS: windows
  • Browser: chrome
@reckart
Copy link
Member

reckart commented Feb 1, 2022

Hm, yes I can see it. Thanks for reporting.

@reckart reckart added this to the 22.3 milestone Feb 1, 2022
@reckart reckart added this to 🔖 To do in Kanban via automation Feb 1, 2022
@reckart reckart added Module: Annotation 🐛Bug Something isn't working labels Feb 1, 2022
@reckart reckart self-assigned this Feb 2, 2022
@reckart
Copy link
Member

reckart commented Feb 2, 2022

This is one of the cases where I scratch my head and wonder "how could this ever have worked..."

reckart added a commit that referenced this issue Feb 2, 2022
@reckart
#2837 - When marking a sequence in RTL it marks only the last character
b35a11e 
- Fix calculation of start position
reckart added a commit that referenced this issue Feb 3, 2022
@reckart
Merge pull request #2838 from inception-project/bugfix/2837-When-mark…
673b977 
…ing-a-sequence-in-RTL-it-marks-only-the-last-character

#2837 -  When marking a sequence in RTL it marks only the last character
reckart added a commit that referenced this issue Feb 3, 2022
@reckart
Merge branch 'release/22.x'
1bd3da2 
* release/22.x:
  #2839 - Upgrade dependencies
  #2837 -  When marking a sequence in RTL it marks only the last character
  #2831 - Cannot search for this & that in annotation sidebar

% Conflicts:
%	inception/pom.xml
@reckart reckart closed this as completed Feb 3, 2022
Kanban automation moved this from 🔖 To do to 🍹 Done Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Annotation
Projects
Kanban
  
🍹 Done
Milestone
22.3
Development

No branches or pull requests
2 participants
@reckart @shaked571