Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to filter entity candidates via typing #48

Closed
reckart opened this issue Apr 12, 2018 · 2 comments
Closed

Ability to filter entity candidates via typing #48

reckart opened this issue Apr 12, 2018 · 2 comments
Assignees
@rcffc
Labels
⭐️ Enhancement New feature or request Module: Entity Linking
Projects
Entity Linking [M1]
Milestone
0.3.0

Comments

@reckart
Copy link
Member

reckart commented Apr 12, 2018

After a user marks an entity, he gets a ranked list of candidates.
He should be able to browse the Instance Selector in the AnnotationDetailEditorPanel (ConceptFeatureEditor) by typing.
Kendo Combo Box could be useful for this task.
@reckart reckart added this to the 0.3.0 milestone Apr 12, 2018
reckart pushed a commit that referenced this issue Apr 12, 2018
@reckart
#48 - Ability to filter entity candidates via typing
773b78b 
- Implemented first try with Kendo AutoCompleteTextField
reckart pushed a commit that referenced this issue Apr 12, 2018
@reckart
#48 - Ability to filter entity candidates via typing
304f0ad 
- Fire two queries each time the user is typing: The first query retrieves candidates containing the mention marked in the text, the second one for the typed string. The candidate sets are then ranked jointly.
reckart pushed a commit that referenced this issue Apr 12, 2018
@reckart
#48 - Ability to filter entity candidates via typing
4180e89 
- Use KBHandle as model instead of String
reckart added a commit that referenced this issue Apr 12, 2018
@reckart
#48 - Ability to filter entity candidates via typing
9ca4fd8 
- TextRenderer must use "uiLabel", not "name" to obtain the correct label for a KBHandle.
- Remove the "new Model<KBHandle>()" from the AutoCompleteTextField which prevented the field to write its data to the "value" field of the FeatureState and instead wrote it into the provided model.
- Remove onSelected() method which was just used for debugging and also produced an error if getName() returned null.
reckart pushed a commit that referenced this issue Apr 12, 2018
@reckart
#48 - Ability to filter entity candidates via typing
a154831 
- remove DropdownList - dropped in favor of AutoCompleteTextField
- filter instances by typing also when concept linking is not supported
rcffc pushed a commit that referenced this issue Apr 13, 2018
#48 - Ability to filter entity candidates via typing
e29cd66 
Improved Candidate Ranking by removing semantic search query
rcffc pushed a commit that referenced this issue Apr 13, 2018
#48 - Ability to filter entity candidates via typing
a00e161 
Increase Candidate query limit since otherwise some candidates are not there - and the extra time is just an increase of ~0.7s
rcffc pushed a commit that referenced this issue Apr 13, 2018
#48 - Ability to filter entity candidates via typing
2781765 
Limit the number of candidates displayed in UI to 20.
rcffc pushed a commit that referenced this issue Apr 13, 2018
#48 - Ability to filter entity candidates via typing
a63c84e 
Parallelized candidate retrieval to decrease response time
rcffc pushed a commit that referenced this issue Apr 13, 2018
#48 - Ability to filter entity candidates via typing
62183f6 
Removed pre-filtering for entity frequency
@reckart
Copy link
Member Author

reckart commented Apr 14, 2018

@rcffc merged #49 - does it fully resolve this issue?

@rcffc
Copy link
Contributor

rcffc commented Apr 15, 2018

Yes

@rcffc rcffc closed this as completed Apr 15, 2018
@reckart reckart added this to To do in Entity Linking [M1] via automation Jun 9, 2018
@reckart reckart moved this from To do to Done in Entity Linking [M1] Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcffc rcffc

Labels
⭐️ Enhancement New feature or request Module: Entity Linking
Projects
No open projects
Entity Linking [M1]
  
Done
Milestone
0.3.0
Development

No branches or pull requests
2 participants
@reckart @rcffc