Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3887 - Allow selecting a concept by browsing the KB #3888

Merged
merged 7 commits into from Mar 28, 2023
Merged

#3887 - Allow selecting a concept by browsing the KB #3888

merged 7 commits into from Mar 28, 2023

Conversation

reckart
Copy link
Member

@reckart reckart commented Mar 20, 2023 •
edited

What's in the PR

  • Added browser button to simple concept feature editor
  • Browsing is only enabled if the feature is bound to concept, instance or any (properties are not supported) and if there is either only one KB in the project or if the feature is bound to a specific KB (since there is no way to switch between KBs in the browser or to browse cross KB).

How to test manually

  • Configure a concept feature to a specific KB and allowing any value
  • Annotate a document and in particular use the browser button in the concept feature editor
  • If the concept editor already contains a value, the path to that value should be expanded - if it is an instance, the instance should be highlighed

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#3887 - Allow selecting a concept by browsing the KB
a2cdbaf 
- Added browser button to simple concept feature editor
- Browsing is only enabled if the feature is bound to a specific KB and only if any value type is allowed on the feature
@reckart reckart added this to the 28.0 milestone Mar 20, 2023
@reckart reckart self-assigned this Mar 20, 2023
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Mar 20, 2023
@reckart
Merge branch 'main' into feature/3887-Allow-selecting-a-concept-by-br…
9d79ebf 
…owsing-the-KB

* main:
  #3868 - Allow a recommender to force-create annotations
  #3895 - Cannot set value in lookup feature editor when there are constraints
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-27.2
  #3890 - Annotations not created if mouse is released on empty space
  #3884 - Telemetry enable setting toggle logic inverted
  No issue. JavaDoc.
@reckart
#3887 - Allow selecting a concept by browsing the KB
eeef403 
- Allow access to browser in more cases - now only hidden for property features and if there is more than one KB in the project and the concept feature is not bound to a specific one
- Improve scroll-to behavior in browser
@reckart
Merge branch 'main' into feature/3887-Allow-selecting-a-concept-by-br…
f3ccb10 
…owsing-the-KB

* main:
  #3900 - Remember project list sort order
@reckart
#3887 - Allow selecting a concept by browsing the KB
f1086b0 
- Formatting
@reckart
#3887 - Allow selecting a concept by browsing the KB
5f55b76 
- Fix NPE
@reckart reckart marked this pull request as ready for review March 28, 2023 06:50
@reckart reckart merged commit 319d4e7 into main Mar 28, 2023
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Mar 28, 2023
@reckart reckart deleted the feature/3887-Allow-selecting-a-concept-by-browsing-the-KB branch March 28, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: Annotation Module: Entity Linking Module: Knowledge Base
Projects
Kanban
  
🍹 Done
Milestone
28.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@reckart