Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3944 - Ability to use recommenders as curator #3949

Merged
merged 9 commits into from Apr 18, 2023
Merged

#3944 - Ability to use recommenders as curator #3949

merged 9 commits into from Apr 18, 2023

Conversation

reckart
Copy link
Member

@reckart reckart commented Apr 15, 2023 •
edited

What's in the PR

  • Recommendation render is not skipped when viewing the curation document (or another users annotations)
  • When viewing another users or the curation users' annotations generate suggestions based on the annotation document of those users
  • When switching between viewing the own document or the annotations of another user / curation user, clear the prediction state for the current user
  • Clean up recommendation rendering code a bit
  • Turn recommendation renders into proper beans

How to test manually

  • Enable/disable curation mode via the sidebar
  • Switch between curating to the own document and to the curation document

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#3944 - Ability to use recommenders as curator
de043d0 
- Remove condition in suggestion renderer to not render when not viewing the own document
- Clean up recommendation rendering code a bit
- Turn recommendation renders into proper beans
@reckart reckart added this to the 28.0 milestone Apr 15, 2023
@reckart reckart self-assigned this Apr 15, 2023
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation Apr 15, 2023
@reckart
Merge branch 'main' into feature/3944-Ability-to-use-recommenders-as-…
599c274 
…curator

* main:
  #3945 - Centralize handling of CURATION_USER
  #3947 - Show more timing information in recommender log
  #3945 - Centralize handling of CURATION_USER
  #3934 - Cannot merge link feature with same target on curation page
  #3932 - Upgrade dependencies
  #3932 - Upgrade dependencies
@reckart
#3944 - Ability to use recommenders as curator
377e69b 
- Clean up training task code
@reckart
Merge branch 'main' into feature/3944-Ability-to-use-recommenders-as-…
b7b8ed3 
…curator

* main:
  #3932 - Upgrade dependencies
@reckart
Merge branch 'main' into feature/3944-Ability-to-use-recommenders-as-…
6b4ddc2 
…curator

* main:
  #3918 - PubMed Central support
@reckart
#3944 - Ability to use recommenders as curator
5723a03 
- Towards separating the context owner from the data owner
@reckart
#3944 - Ability to use recommenders as curator
d7c6741 
- Rename methods and variables to better reflect the separation between session owner and document owner
@reckart
Merge branch 'main' into feature/3944-Ability-to-use-recommenders-as-…
8370acb 
…curator

* main:
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-27.6
  #3958 - Dynamically sized multi-line string fields no resize automatically
  #3957 - Cannot create project using project-creator role
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-27.5
  #3932 - Upgrade dependencies
  #3953 - Switch core footer items to auto-configuration
  #3951 - Lots of errors and warnings from logging system during startup
  No issue: Demote some logged message to debug level
  #3940 - Merge label into eligible existing annotation even when stacking is enabled

% Conflicts:
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/service/RecommendationServiceImpl.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/PredictionTask.java
@reckart
#3944 - Ability to use recommenders as curator
c179658 
- Clear and regenerate the users' predictions when switching the data they look on
@reckart reckart marked this pull request as ready for review April 18, 2023 19:59
@reckart reckart merged commit 2ccfe1e into main Apr 18, 2023
1 check passed
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Apr 18, 2023
@reckart reckart deleted the feature/3944-Ability-to-use-recommenders-as-curator branch April 18, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: Curation
Projects
Kanban
  
🍹 Done
Milestone
28.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@reckart