Fix template instantiation reporting #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolshakov-a
commented
Nov 6, 2022
kimgr
reviewed
Nov 27, 2022
bolshakov-a
force-pushed
the
reporting_template_spec_fix
branch
from
de19606
to
4c6bfed
Compare
kimgr
reviewed
Dec 13, 2022
bolshakov-a
force-pushed
the
reporting_template_spec_fix
branch
from
9d9a822
to
6ee423a
Compare
Names starting with an underscore aren't allowed in a global namespace, according to the standard.
Full template specialization type use requires full information about its template-argument-dependent fields and nested typedefs. But earlier, it wasn't reported in many cases when template specialization type isn't written explicitly in non-fwd-decl context.
Non-sugared template specialization type template arguments are already analyzed due to 'TraverseType' call inside 'InstantiatedTemplateVisitor::TraverseSubstTemplateTypeParmTypeHelper' and subsequent 'TraverseTemplateSpecializationTypeHelper' call. Components of sugared template specialization types are added into resugar_map, otherwise their template arguments would not be reported. Test case has been extended.
It became superfluous after generalization of reporting types needed for template instantiation.
bolshakov-a
force-pushed
the
reporting_template_spec_fix
branch
from
6ee423a
to
88fb8cb
Compare
|
Excellent, thanks! |
This was referenced Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full template specialization type use requires full information about its template-argument-dependent fields and nested typedefs. But earlier, it wasn't reported in many cases when template specialization type isn't written explicitly in non-fwd-decl context.