Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for always_keep pragma #1253

Closed
wants to merge 1 commit into from

Conversation

kadircet
Copy link

@kadircet kadircet commented May 1, 2023

No description provided.

@kimgr
Copy link
Contributor

kimgr commented May 21, 2023

Discussions on pragma naming ongoing in: #1235

@kadircet
Copy link
Author

rebase to pick up CI fix.

Fixes #1235.

@kimgr
Copy link
Contributor

kimgr commented May 22, 2023

Might be a good idea to also cover always_keep in the summary section at the end: https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md#which-pragma-should-i-use.

We can't really merge this until the pragma is implemented. The semantics look right to me, do you want to take a stab at it, or should I?

@kadircet
Copy link
Author

Might be a good idea to also cover always_keep in the summary section at the end: https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md#which-pragma-should-i-use.

Thanks, updated that part too.

We can't really merge this until the pragma is implemented. The semantics look right to me, do you want to take a stab at it, or should I?

It'd be great if you can take a stab at that, as I am not really familiar with the codebase

@kadircet
Copy link
Author

kadircet commented Jul 5, 2023

hi! did you get a chance to look at the implementation here?

i am planning to introduce this pragma handling to LLVM soon, it'd be quite useful if the docs are updated for that one.

@kimgr
Copy link
Contributor

kimgr commented Jul 5, 2023

I haven't had a chance yet, but I'll try to get this in motion.

@kimgr
Copy link
Contributor

kimgr commented Jul 6, 2023

Superseded by full implementation in #1272

@kimgr kimgr closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants