Exclude prefix headers from macro-defined-by-includer heuristics (issue #368). #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include-what-you-use#368). Also considered options of not populating `macro_users_` or `direct_includes_as_fileentries_` for prefix headers but decided not to do so. I think it is better to have correct information for prefix headers but not to give recommendations based on that instead of having incomplete information.
kimgr
approved these changes
Feb 19, 2017
| @@ -1889,6 +1889,13 @@ size_t PrintableDiffs(const string& filename, | |||
| void IwyuFileInfo::HandlePreprocessingDone() { | |||
| // Check macros defined by includer. Requires file preprocessing to be | |||
| // finished to know all direct includes and all macro usages. | |||
| // | |||
| // Exclude prefix headers from mapping heuristics. Includes in prefix | |||
| // headers are kept regardless of their usage in includer. And entire | |||
|
Looks like our mailbot doesn't pick up the new GitHub reviews. See above. |
vsapsai
added a commit
to vsapsai/include-what-you-use
that referenced
this pull request
Feb 20, 2017
include-what-you-use#368). Also considered options of not populating `macro_users_` or `direct_includes_as_fileentries_` for prefix headers but decided not to do so. I think it is better to have correct information for prefix headers but not to give recommendations based on that instead of having incomplete information. PR include-what-you-use#410
|
Merged 7cb24d2 with comment fix. |
huizongsong
pushed a commit
to huizongsong/include-what-you-use
that referenced
this pull request
Aug 26, 2022
…ue #368). Also considered options of not populating `macro_users_` or `direct_includes_as_fileentries_` for prefix headers but decided not to do so. I think it is better to have correct information for prefix headers but not to give recommendations based on that instead of having incomplete information. PR include-what-you-use/include-what-you-use#410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also considered options of not populating
macro_users_ordirect_includes_as_fileentries_for prefix headers but decided not todo so. I think it is better to have correct information for prefix
headers but not to give recommendations based on that instead of having
incomplete information.