Require Faraday v2 #22
Merged
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nipe0324
commented
Oct 15, 2023
| @@ -341,6 +341,10 @@ def stub_api_request | |||
| 204 | |||
| end | |||
|
|
|||
| let(:response_hash) do | |||
| nil | |||
| end | |||
There was a problem hiding this comment.
Returns empty body response if 204 status code.
And, Qiita PUT and DELETE APIs return a empty body.
JSON Schema(en): https://qiita.com/api/v2/schema?locale=en
|
@nipe0324 |
nipe0324
force-pushed
the
require-faraday-v1-or-v2
branch
from
e67e089
to
688bab4
Compare
|
@getty104 |
|
@nipe0324 |
getty104
approved these changes
Oct 24, 2023
| @@ -2,7 +2,6 @@ | |||
| require "active_support/core_ext/string/inflections" | |||
| require "active_support/core_ext/string/strip" | |||
| require "faraday" | |||
| require "faraday_middleware" | |||
There was a problem hiding this comment.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest Faraday version is v2. But, qiita-rb supports only v0.x.
I tried to change that qiita-rb requires Faraday v2.