Fix Net::HTTP adapter so that it returns nil for an empty body response.
#190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onse. This mirrors the real behavior of Net::HTTP and is the source of myronmarston/vcr#173. A couple things to note: - Rather than hitting an external URL (httpstat.us/204), this should probably hit the local webmock server; however, I can't figure out how to make the webmock server return a different response for different requests since it's writing directly to the socket w/o any request context available. Maybe it should be refactored to use rack or sinatra? - I have no idea why, but Curb is returning a 400 Bad Request response for the request. Weird. Not sure why or how to fix it.
|
Thanks Myron. Clever approach to test that. I'll create a patch release once I figure out what's going on with curb. |
|
What are your thoughts on the idea of refactoring the webmock server? This spec is currently hitting an external URL, as is my spec in #185. It'd be nice to make them hit the webmock server but they need a particular response and I couldn't figure out how to conditionally return a response based on the request in your current setup. |
bblimke
added a commit
that referenced
this pull request
Jul 23, 2012
Fix Net::HTTP adapter so that it returns `nil` for an empty body response.
ytuauden
pushed a commit
to ytuauden/linkedin-v2-oauth2
that referenced
this pull request
Jul 18, 2022
This was referenced Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the real behavior of Net::HTTP and is the source of myronmarston/vcr#173.
A couple things to note:
hit the local webmock server; however, I can't figure out how to make the
webmock server return a different response for different requests since it's
writing directly to the socket w/o any request context available. Maybe it
should be refactored to use rack or sinatra?
the request. Weird. Not sure why or how to fix it.