-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README #31
Updated README #31
Conversation
Added better description.
@meshy reverted my master commits |
@jturnbull there two other commits that did not get reverted by the looks of it. |
...and it would have been better to PR the fix for |
@meshy all three commits were reverted, despite the comment.
Why? This way you can review all the changes in one place |
So that the code change can be reviewed. There was no need to add a revert. The change was fundamentally sound, but it introduced a bug. Better to fix the bug. |
I thought PyPI doesn't support markdown? |
Also, if you revert more than one commit together in a bunch again, please add the commit hashes to the commit message. |
@Ian-Foote it doesn't. |
url='https://github.com/incuna/django-orderable', | ||
long_description=open('README.rst').read(), | ||
long_description=open('README.md').read(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to drop the long_description
, or should we continue to use rst
? Or is there another solution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should continue to provide a markdown long description.
Current Coverage via 24cca87 is
|
@meshy should I try to up the coverage in this PR? ;) |
Haha! I think we can let that one slip |
Added better description.
@meshy please review