Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when opening 90% of the issues #89

Closed
ribx opened this issue Apr 4, 2014 · 8 comments · Fixed by #94
Closed

Crash when opening 90% of the issues #89

ribx opened this issue Apr 4, 2014 · 8 comments · Fixed by #94
Assignees
Labels
Milestone

Comments

@ribx
Copy link

ribx commented Apr 4, 2014

I am not sure, what is the reason for the Crashes. I just noticed that closed tickets are displayed correctly. Whenever I open one of the offer tickets, I get a "openredmine has been closed" dialog.

What could be the reason? We use some extension for redmine and we are on one of the latest versions. Could an extension be responsible?

What info should I provide?

@indication
Copy link
Owner

We needs your android's logs (get via aLogcat etc.) and version(Android 4.3 or what ever).
Please pick the log containning jp.redmine.redmineclient and put here because the logs may be contained your sensitive information.

For my note (This is guess): The bug is possibly happens:

  1. Create new issue
  2. The issue status or something would be wrong
  3. Server returns wrong status code.
  4. OpenRedmine referenced null on jp.redmine.redmineclient.fragment.IssueEdit.SelectIssuePost.onPostExecute -- result.get(0).getIssueId()

@indication
Copy link
Owner

Is this your log ?
On 3/26 18:16(GMT+9 or GMT), Android 2.3.3 - 2.3.7 Galaxy *******.

java.lang.NullPointerException
at android.widget.Toast.makeText(Toast.java:284)
at jp.redmine.redmineclient.fragment.IssueEdit$1.onPostExecute(IssueEdit.java:184)
at jp.redmine.redmineclient.fragment.IssueEdit$1.onPostExecute(IssueEdit.java:159)
at android.os.AsyncTask.finish(AsyncTask.java:417)
at android.os.AsyncTask.access$300(AsyncTask.java:127)
at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:429)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:130)
at android.app.ActivityThread.main(ActivityThread.java:3770)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:507)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:912)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:670)
at dalvik.system.NativeStart.main(Native Method)

Others(2) happened in Toast.

@ribx
Copy link
Author

ribx commented Apr 8, 2014

My openredmine version is 3.8, the version from the fdroid app repo. I am running CyanogenMod nightly from 2014-03-05, which means android 4.4.2, without Google apps.

I check for the back trace later. I first have to check how this works.

Sorry for the late answer, I just return from my vacations.

-ribx

@ribx
Copy link
Author

ribx commented Apr 18, 2014

Here is my log. I also have some "date cannot be parsed" then a date linke "yyyy-mm-dd HH:MM.decimals GMT", but they are not fatal.

04-18 18:56:55.423 E/notifyDataCreation(16873): Catch exception
04-18 18:56:55.423 E/notifyDataCreation(16873): java.lang.NullPointerException
04-18 18:56:55.423 E/notifyDataCreation(16873): at java.util.Date.before(Date.java:178)
04-18 18:56:55.423 E/notifyDataCreation(16873): at jp.redmine.redmineclient.db.cache.RedmineIssueModel.refreshItem(RedmineIssueModel.java:164)
04-18 18:56:55.423 E/notifyDataCreation(16873): at jp.redmine.redmineclient.db.cache.RedmineIssueModel.refreshItem(RedmineIssueModel.java:151)
04-18 18:56:55.423 E/notifyDataCreation(16873): at jp.redmine.redmineclient.parser.IssueModelDataCreationHandler.onData(IssueModelDataCreationHandler.java:62)
04-18 18:56:55.423 E/notifyDataCreation(16873): at jp.redmine.redmineclient.parser.IssueModelDataCreationHandler.onData(IssueModelDataCreationHandler.java:25)
04-18 18:56:55.423 E/notifyDataCreation(16873): at jp.redmine.redmineclient.parser.BaseParser.notifyDataCreation(BaseParser.java:127)
04-18 18:56:55.423 E/notifyDataCreation(16873): at jp.redmine.redmineclient.parser.BaseParserInternal.onTagEnd(BaseParserInternal.java:43)
04-18 18:56:55.423 E/notifyDataCreation(16873): at jp.redmine.redmineclient.parser.BaseParser.parse(BaseParser.java:88)
04-18 18:56:55.423 E/notifyDataCreation(16873): at jp.redmine.redmineclient.task.SelectIssueJournalTask$2.onContent(SelectIssueJournalTask.java:84)
04-18 18:56:55.423 E/notifyDataCreation(16873): at jp.redmine.redmineclient.task.SelectDataTask$2.handleResponse(SelectDataTask.java:239)
04-18 18:56:55.423 E/notifyDataCreation(16873): at jp.redmine.redmineclient.task.SelectDataTask$2.handleResponse(SelectDataTask.java:214)
04-18 18:56:55.423 E/notifyDataCreation(16873): at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:657)
04-18 18:56:55.423 E/notifyDataCreation(16873): at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:627)
04-18 18:56:55.423 E/notifyDataCreation(16873): at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:616)
04-18 18:56:55.423 E/notifyDataCreation(16873): at jp.redmine.redmineclient.task.SelectDataTask.fetchData(SelectDataTask.java:214)
04-18 18:56:55.423 E/notifyDataCreation(16873): at jp.redmine.redmineclient.task.SelectDataTask.fetchData(SelectDataTask.java:149)
04-18 18:56:55.423 E/notifyDataCreation(16873): at jp.redmine.redmineclient.task.SelectDataTask.fetchData(SelectDataTask.java:131)
04-18 18:56:55.423 E/notifyDataCreation(16873): at jp.redmine.redmineclient.task.SelectIssueJournalTask.doInBackgroundIssue(SelectIssueJournalTask.java:95)
04-18 18:56:55.423 E/notifyDataCreation(16873): at jp.redmine.redmineclient.task.SelectIssueJournalTask.doInBackground(SelectIssueJournalTask.java:48)
04-18 18:56:55.423 E/notifyDataCreation(16873): at jp.redmine.redmineclient.task.SelectIssueJournalTask.doInBackground(SelectIssueJournalTask.java:30)
04-18 18:56:55.423 E/notifyDataCreation(16873): at android.os.AsyncTask$2.call(AsyncTask.java:288)
04-18 18:56:55.423 E/notifyDataCreation(16873): at java.util.concurrent.FutureTask.run(FutureTask.java:237)
04-18 18:56:55.423 E/notifyDataCreation(16873): at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
04-18 18:56:55.423 E/notifyDataCreation(16873): at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
04-18 18:56:55.423 E/notifyDataCreation(16873): at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
04-18 18:56:55.423 E/notifyDataCreation(16873): at java.lang.Thread.run(Thread.java:841)
04-18 18:56:55.423 W/dalvikvm(16873): threadid=15: thread exiting with uncaught exception (group=0x41842ce0)
04-18 18:56:55.433 E/AndroidRuntime(16873): FATAL EXCEPTION: AsyncTask #3
04-18 18:56:55.433 E/AndroidRuntime(16873): Process: jp.redmine.redmineclient, PID: 16873
04-18 18:56:55.433 E/AndroidRuntime(16873): java.lang.RuntimeException: An error occured while executing doInBackground()
04-18 18:56:55.433 E/AndroidRuntime(16873): at android.os.AsyncTask$3.done(AsyncTask.java:300)
04-18 18:56:55.433 E/AndroidRuntime(16873): at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:355)
04-18 18:56:55.433 E/AndroidRuntime(16873): at java.util.concurrent.FutureTask.setException(FutureTask.java:222)
04-18 18:56:55.433 E/AndroidRuntime(16873): at java.util.concurrent.FutureTask.run(FutureTask.java:242)
04-18 18:56:55.433 E/AndroidRuntime(16873): at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
04-18 18:56:55.433 E/AndroidRuntime(16873): at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
04-18 18:56:55.433 E/AndroidRuntime(16873): at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
04-18 18:56:55.433 E/AndroidRuntime(16873): at java.lang.Thread.run(Thread.java:841)
04-18 18:56:55.433 E/AndroidRuntime(16873): Caused by: java.util.ConcurrentModificationException
04-18 18:56:55.433 E/AndroidRuntime(16873): at java.util.ArrayList$ArrayListIterator.next(ArrayList.java:573)
04-18 18:56:55.433 E/AndroidRuntime(16873): at jp.redmine.redmineclient.parser.BaseParser.notifyDataCreation(BaseParser.java:125)
04-18 18:56:55.433 E/AndroidRuntime(16873): at jp.redmine.redmineclient.parser.BaseParserInternal.onTagEnd(BaseParserInternal.java:43)
04-18 18:56:55.433 E/AndroidRuntime(16873): at jp.redmine.redmineclient.parser.BaseParser.parse(BaseParser.java:88)
04-18 18:56:55.433 E/AndroidRuntime(16873): at jp.redmine.redmineclient.task.SelectIssueJournalTask$2.onContent(SelectIssueJournalTask.java:84)
04-18 18:56:55.433 E/AndroidRuntime(16873): at jp.redmine.redmineclient.task.SelectDataTask$2.handleResponse(SelectDataTask.java:239)
04-18 18:56:55.433 E/AndroidRuntime(16873): at jp.redmine.redmineclient.task.SelectDataTask$2.handleResponse(SelectDataTask.java:214)
04-18 18:56:55.433 E/AndroidRuntime(16873): at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:657)
04-18 18:56:55.433 E/AndroidRuntime(16873): at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:627)
04-18 18:56:55.433 E/AndroidRuntime(16873): at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:616)
04-18 18:56:55.433 E/AndroidRuntime(16873): at jp.redmine.redmineclient.task.SelectDataTask.fetchData(SelectDataTask.java:214)
04-18 18:56:55.433 E/AndroidRuntime(16873): at jp.redmine.redmineclient.task.SelectDataTask.fetchData(SelectDataTask.java:149)
04-18 18:56:55.433 E/AndroidRuntime(16873): at jp.redmine.redmineclient.task.SelectDataTask.fetchData(SelectDataTask.java:131)
04-18 18:56:55.433 E/AndroidRuntime(16873): at jp.redmine.redmineclient.task.SelectIssueJournalTask.doInBackgroundIssue(SelectIssueJournalTask.java:95)
04-18 18:56:55.433 E/AndroidRuntime(16873): at jp.redmine.redmineclient.task.SelectIssueJournalTask.doInBackground(SelectIssueJournalTask.java:48)
04-18 18:56:55.433 E/AndroidRuntime(16873): at jp.redmine.redmineclient.task.SelectIssueJournalTask.doInBackground(SelectIssueJournalTask.java:30)
04-18 18:56:55.433 E/AndroidRuntime(16873): at android.os.AsyncTask$2.call(AsyncTask.java:288)
04-18 18:56:55.433 E/AndroidRuntime(16873): at java.util.concurrent.FutureTask.run(FutureTask.java:237)
04-18 18:56:55.433 E/AndroidRuntime(16873): ... 4 more

@indication
Copy link
Owner

I've got what a hell's going on in this issue!

The problem is in TypeConvert class.
An input date could not be parsed because that define yyyy-mm-ddThh:mm:ss to parse to date.

We gonna make a patch to fix this.
Thank you a lot for reporting and testing.

@ribx
Copy link
Author

ribx commented Apr 19, 2014

I am not sure about that, because these exceptions are not fatal.

I checked the problem again yesterday and it looks like the creation date is missing for most of my issues.

Strange thing is, that all are created with the webfrontend. And even more strange: it looks like always the first and the last item in the openredmine list of a project has the creation date.

Maybe it is connected to the parsing problem, but why the first and the last ticket in the overview has the date?

@ribx
Copy link
Author

ribx commented May 15, 2014

Works like charme, thanks alot!

@indication
Copy link
Owner

Thank you for feedback and testing again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants