Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set sane defaults in logging.conf #1829

Closed
pferreir opened this issue Apr 3, 2015 · 4 comments
Closed

Set sane defaults in logging.conf #1829

pferreir opened this issue Apr 3, 2015 · 4 comments
Assignees
@mic4ael
Labels
enhancement p-essential trivial
Milestone
v1.9.3

Comments

@pferreir
Copy link
Member

pferreir commented Apr 3, 2015

Right now, for instance, we have NOTSET for the global Indico logger. Using INFO for everything (except e-mail) could actually be a good idea.
@pferreir pferreir added this to the v1.9.2 milestone Apr 3, 2015
@pferreir pferreir mentioned this issue Apr 3, 2015
Closed
@pferreir
Copy link
Member Author

pferreir commented Apr 3, 2015

And please backport to 1.2.

@ThiefMaster
Copy link
Member

Using logging.yml instead of logging.conf would also be a nice thing for a future version. The ini format for logging is kind of terrible.

@pferreir
Copy link
Member Author

pferreir commented Apr 3, 2015

Indeed, but let's open a separate ticket for that, for a future release.

@DirkHoffmann
Copy link
Member

Also keep in mind that there seem to be two different logging systems available. One is configured in indico.conf, the python logging is then configured in logging.conf. Would be better to have everything concerning logging (choice of system + logging levels) in the same place.
Regarding e-mail, I think they are going out for errors only anyway. I did not find a configuration for that. May be hardcoded 😱

@pferreir pferreir modified the milestones: v1.9.3, v1.9.2 May 6, 2015
@mic4ael mic4ael self-assigned this Jun 2, 2015
mic4ael added a commit to mic4ael/indico that referenced this issue Jun 2, 2015
@mic4ael
Issue indico#1829 - changed log levels in logging.conf
a3576f6
@ThiefMaster ThiefMaster mentioned this issue Jun 2, 2015
Closed
mic4ael added a commit to mic4ael/indico that referenced this issue Jun 2, 2015
@mic4ael
Use better default log levels
7675629 
fixes indico#1829
mic4ael added a commit to mic4ael/indico that referenced this issue Jun 2, 2015
@mic4ael
Use better default log levels
518690c 
fixes indico#1829
@mic4ael mic4ael closed this as completed in 62ccb45 Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mic4ael mic4ael

Labels
enhancement p-essential trivial
Projects
None yet
Milestone
v1.9.3
Development

No branches or pull requests
4 participants
@pferreir @ThiefMaster @DirkHoffmann @mic4ael