New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session block adjustment: incorrect message wording #3080

Closed
jouvin opened this Issue Sep 29, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@jouvin
Contributor

jouvin commented Sep 29, 2017

When ajusting a session block start/end time based on the session block contents, the message incorrectly says that the session start/end time will be adjusted instead of the session block. Also the expected session block name displayed is the session name (consistent with the wrong wording!) where it should be session:block. And there is also a missing space after the session (block) name.

This is confusing but probably easy to fix!

@ThiefMaster

This comment has been minimized.

Member

ThiefMaster commented Sep 29, 2017

hi, thanks for reporting it. just a small suggestion: in issues related to a message it's good to include that message - that way we can quickly search for it in the codebase ;)

@ThiefMaster

This comment has been minimized.

Member

ThiefMaster commented Sep 29, 2017

I guess you mean the message in the "fit to content" dialog?

@ThiefMaster ThiefMaster added the trivial label Sep 29, 2017

@jouvin

This comment has been minimized.

Contributor

jouvin commented Sep 29, 2017

@ThiefMaster sorry, the problem is that I have the French version of the interface, I should configure my browser to run the English one! But yes, this is the "fit to content" message displayed after you click on the "Fit to content" button.

@mvidalgarcia mvidalgarcia self-assigned this Oct 23, 2017

@mvidalgarcia

This comment has been minimized.

Member

mvidalgarcia commented Oct 23, 2017

And there is also a missing space after the session (block) name.

I can't find it, where do you mean exactly?

mvidalgarcia added a commit to mvidalgarcia/indico that referenced this issue Oct 23, 2017

mvidalgarcia added a commit to mvidalgarcia/indico that referenced this issue Oct 23, 2017

mvidalgarcia added a commit to mvidalgarcia/indico that referenced this issue Oct 23, 2017

ThiefMaster added a commit to mvidalgarcia/indico that referenced this issue Oct 30, 2017

ThiefMaster added a commit to mvidalgarcia/indico that referenced this issue Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment