Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: "Default" themes pinned to the top for event administrators/managers #3166

Closed
RaoOfPhysics opened this issue Nov 24, 2017 · 1 comment
Closed

Comments

@RaoOfPhysics
Copy link

@RaoOfPhysics RaoOfPhysics commented Nov 24, 2017

This concerns the instance at CERN.

When a user is not signed in or is not the administrator of an event, they are presented with a limited set of "default" themes to skin the event:

firefox - - screen shot 24 nov 2017 at 20 58 36

However, when you log in as an administrator or manager, you see a much longer list:

firefox - - screen shot 24 nov 2017 at 20 56 43

Is it possible to show this second list with the "default" themes from the first list pinned to the top and clearly separated (by a line of some sort) from the other options?

Thank you.

@ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented Nov 24, 2017

That sounds like a good idea! These extra themes are provided by a plugin and there's already a user_visible flag that determine whether a theme goes into the short list or not. We could group by events with/without that flag here: https://github.com/indico/indico/blob/master/indico/modules/events/templates/header.html#L41-L42

mvidalgarcia added a commit to mvidalgarcia/indico that referenced this issue Feb 2, 2018
mvidalgarcia added a commit to mvidalgarcia/indico that referenced this issue Feb 5, 2018
mvidalgarcia added a commit to mvidalgarcia/indico that referenced this issue Feb 5, 2018
mvidalgarcia added a commit to mvidalgarcia/indico that referenced this issue Feb 5, 2018
mvidalgarcia added a commit to mvidalgarcia/indico that referenced this issue Feb 5, 2018
mvidalgarcia added a commit to mvidalgarcia/indico that referenced this issue Feb 5, 2018
ThiefMaster added a commit to mvidalgarcia/indico that referenced this issue Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants