Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid URL when booking a room for a multi-days event #4021

Closed
Feandil opened this issue Aug 1, 2019 · 0 comments

Comments

@Feandil
Copy link

commented Aug 1, 2019

Describe the bug

When trying to book a room for multi-days event ('Book' on the Event in Room Booking in Event management), the URL created is for a daily booking from the first day to the last day of the meeting, from the time of the start of the meeting to the time of the end of the meeting.
This work well if the meeting starts and ends every day at the same time, but for a meeting which starts one day after lunch and ends on a following day before lunch the time selected has it's end before its start...

To Reproduce
Steps to reproduce the behavior:

  1. Create an event starting on day X at 13:30 and ending at day X+n at 12:30
  2. Click on 'Room Booking'
  3. Click 'Book'
  4. See error: Something went wrong The provided URL was not properly formatted.

Expected behavior
Well, the correct behavior is difficult to define, as the timeslots of the room booking for daily booking don't really match the event boundaries. At least I'm expecting not to get an error.
A solution could be to give the option to give links to book days independently if they don't start/end at the same time?

@ThiefMaster ThiefMaster added this to the v2.2 milestone Aug 12, 2019

@pferreir pferreir self-assigned this Aug 15, 2019

@pferreir pferreir added this to In progress in Release 2.2 Aug 15, 2019

pferreir added a commit to pferreir/indico that referenced this issue Aug 15, 2019

Release 2.2 automation moved this from In progress to Done Aug 19, 2019

aristofanischionis added a commit to aristofanischionis/indico that referenced this issue Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.