Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open news items on a separate page #4587

Merged
merged 1 commit into from Aug 10, 2020
Merged

Conversation

ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented Aug 10, 2020

Linking to news with all news on the same page is quite awful. We should eventually add pagination there for older news, but being able to link to a specific news item already helps a lot.

Linking to news with all news on the same page is quite awful. We should
eventually add pagination there for older news, but being able to link
to a specific news item already helps a lot.
@ThiefMaster ThiefMaster requested a review from Leats Aug 10, 2020
Leats
Leats approved these changes Aug 10, 2020
Copy link
Contributor

@Leats Leats left a comment

LGTM! Thanks!

@ThiefMaster ThiefMaster merged commit d594aeb into indico:master Aug 10, 2020
4 checks passed
@ThiefMaster ThiefMaster deleted the news branch Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants