Add option to show only unregistered users in participant roles list

CHANGES.rst

@@ -40,6 +40,14 @@ Improvements
   (:pr:`4817`)
 - Failed login attempts now trigger rate limiting to prevent brute-force attacks
   (:issue:`1550`, :pr:`4817`)
+- Allow filtering the "Participant Roles" page by users who have not registered for the event
+  (:issue:`4763`, :pr:`4822`)
+
+Bugfixes
+^^^^^^^^
+
+- Take registrations of users who are only members of a custom event role into account on the
+  "Participant Roles" page (:pr:`4822`)
 
 Internal Changes
 ^^^^^^^^^^^^^^^^

indico/modules/events/management/client/js/index.js

@@ -107,7 +107,7 @@ import './badges';
   function toggleResetBtn() {
     const isInitialState =
       $('#person-filters [data-filter]:checked').length ===
-      $('#person-filters [data-filter]:not(#filter-no-account)').length;
+      $('#person-filters [data-filter]:not(#filter-no-account,#filter-no-registration)').length;
     $('.js-reset-role-filter').toggleClass('disabled', isInitialState);
   }
 
@@ -129,6 +129,7 @@ import './badges';
     options = $.extend(
       {
         hasNoAccountFilter: false,
+        hasNoRegistrationFilter: false,
       },
       options
     );
@@ -235,6 +236,27 @@ import './badges';
       });
     }
 
+    if (options.hasNoRegistrationFilter) {
+      $('.js-event-person-list [data-filter]:not(#filter-no-registration)').on(
+        'change',
+        function() {
+          $('#filter-no-registration').prop('checked', false);
+          refreshPersonFilters();
+          applySearchFilters();
+        }
+      );
+      $('#filter-no-registration').on('change', function() {
+        if (this.checked) {
+          $('.js-event-person-list [data-filter]:checked:not(#filter-no-registration)').prop(
+            'checked',
+            false
+          );
+        }
+        refreshPersonFilters();
+        applySearchFilters();
+      });
+    }
+
     initTooltip();
 
     const $personFilters = $('#person-filters');
@@ -248,8 +270,10 @@ import './badges';
     $personFilters.find('.js-reset-role-filter').on('click', function() {
       $('.js-event-person-list [data-filter]').each(function() {
         const $this = $(this);
-        $this.prop('checked', !$this.is('#filter-no-account'));
-        $this.parent().toggleClass('enabled', !$this.is('#filter-no-account'));
+        $this.prop('checked', !$this.is('#filter-no-account, #filter-no-registration'));
+        $this
+          .parent()
+          .toggleClass('enabled', !$this.is('#filter-no-account, #filter-no-registration'));
       });
       refreshPersonFilters();
       applySearchFilters();

indico/modules/events/persons/controllers.py

@@ -169,6 +169,7 @@ def get_persons(self):
 
         internal_role_users = defaultdict(lambda: {'roles': {},
                                                    'person': [],
+                                                   'registrations': [],
                                                    'has_event_person': False,
                                                    'id_field_name': 'user_id'})
         for user, roles in event_user_roles.items():
@@ -180,6 +181,13 @@ def get_persons(self):
                 user_metadata['roles'][f'custom_{role.id}'] = {'name': role.name, 'code': role.code, 'css': role.css}
             user_metadata['roles'] = dict(sorted(user_metadata['roles'].items(), key=lambda x: x[1]['code']))
 
+        regs = (Registration.query
+                .with_parent(self.event)
+                .filter(Registration.user_id.in_(data['person'].id for data in internal_role_users.values()))
+                .all())
+        for reg in regs:
+            internal_role_users[reg.user.email]['registrations'].append(reg)
+
         # Some EventPersons will have no roles since they were connected to deleted things
         persons = {email: data for email, data in persons.items() if any(data['roles'].values())}
         persons = dict(persons, **internal_role_users)
@@ -218,6 +226,9 @@ def _process(self):
                 num_no_account += 1
         custom_roles = {f'custom_{r.id}': {'name': r.name, 'code': r.code, 'color': r.color}
                         for r in self.event.roles}
+        for person_data in persons.values():
+            if not person_data['registrations']:
+                person_data['roles']['no_registration'] = True
         return WPManagePersons.render_template('management/person_list.html', self.event, persons=person_list,
                                                num_no_account=num_no_account, builtin_roles=BUILTIN_ROLES,
                                                custom_roles=custom_roles)

indico/modules/events/persons/templates/management/_person_list_row.html

@@ -44,7 +44,7 @@
     </td>
     <td class="i-table roles-column">
         {% for role, role_data in person_data.roles.items() %}
-            {%- if role != 'no_account' %}
+            {%- if role not in ('no_account', 'no_registration') %}
                 {%- if role_data.elements -%}
                     <span class="i-tag outline contrast js-count-label" style="{{ role_data.css }};"
                           data-role-name="{{ role_data.name }}"

indico/modules/events/persons/templates/management/person_list.html

@@ -176,6 +176,15 @@
                             <i class="icon-stop colored-square no-account"></i>
                             <label for="filter-no-account">{% trans %}Users with no account{% endtrans %}</label>
                         </li>
+                        <li class="separator">
+                            <span class="titled-rule">{% trans %}or{% endtrans %}</span>
+                        </li>
+                        <li for="filter-no-registration">
+                            <input type="checkbox" id="filter-no-registration" data-filter="no_registration">
+                            <i class="icon-checkmark"></i>
+                            <i class="icon-stop colored-square no-registration"></i>
+                            <label for="filter-no-registration">{% trans %}Unregistered users{% endtrans %}</label>
+                        </li>
                     </ul>
                     <a class="i-button highlight icon-close disabled js-reset-role-filter"
                        title="{% trans %}Reset role filters{% endtrans %}"></a>
@@ -237,7 +246,8 @@
     </div>
     <script>
         setupEventPersonsList({
-            hasNoAccountFilter: true
+            hasNoAccountFilter: true,
+            hasNoRegistrationFilter: true
         });
     </script>
 {% endblock %}

indico/web/client/styles/modules/abstracts/_roles.scss

@@ -120,6 +120,10 @@
         color: $yellow;
       }
 
+      .icon-stop.no-registration {
+        color: $orange;
+      }
+
       span.titled-rule {
         width: 100%;
       }