Bump react to 17 #14
Bump react to 17 #14
Conversation
| "rimraf": "^3.0.0", | ||
| "rollup": "^2.9.1", | ||
| "rollup-plugin-peer-deps-external": "^2.2.0" | ||
| "rollup-plugin-peer-deps-external": "^2.2.0", | ||
| "@wojtekmaj/enzyme-adapter-react-17": "^0.6.6" |
There was a problem hiding this comment.
this looks like a private fork and package, isn't the official package ready yet? If not, I wouldn't rush with the upgrade
There was a problem hiding this comment.
this looks like a private fork and package, isn't the official package ready yet? If not, I wouldn't rush with the upgrade
I did a bit of research, an at first glace it looks like they just gave up. The issue for supporting React 17 enzymejs/enzyme#2429 is stuck since almost 2 years now, while the fork we chose here looks seriously maintained and widely adopted (550k weekly downloads, the activity on the repo looks legitimate: https://github.com/wojtekmaj/enzyme-adapter-react-17). At this point the choice is either trust this fork or give up on having enzyme.
There was a problem hiding this comment.
Yes I agree, enzyme feels kind of dead, so unless you want to move to something else altogether for testing I think using the fork is the way to go. We use the same fork in Indico BTW.
|
What's the reason for removing package-lock.json altogether? |
My bad, I pushed an updated version of it |
See #13
Also replaces https://www.npmjs.com/package/enzyme-adapter-react-16 with https://www.npmjs.com/package/@wojtekmaj/enzyme-adapter-react-17