Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request_and_load_zip does not load all resources #3

Open
sergeysinyavsky opened this issue Jul 26, 2022 · 1 comment
Open

request_and_load_zip does not load all resources #3

sergeysinyavsky opened this issue Jul 26, 2022 · 1 comment

Comments

@sergeysinyavsky
Copy link

sergeysinyavsky commented Jul 26, 2022

Describe the bug

When I use nil, not all resources are loaded and I don't get any error.

reszip.request_and_load_zip(RES_WEB_PATH, nil, function(self, err) end, http_loading_progress_handler)

And when I try to load collection I get the error:

WARNING:RESOURCE: Resource not found: /sources/game/sounds/both/chest_card_take.oggc

Missing resources can be different.

Expected behavior
All resources are expected to be loaded

Additional context
If I don't use nil then everything works fine.

reszip.request_and_load_zip(RES_WEB_PATH, collectionproxy.missing_resources("someproxy#someproxy"), function(self, err)
end, http_loading_progress_handler)

Defold 1.3.4
defold-liveupdate-reszip v1.2.0

@aglitchman
Copy link
Member

Thanks for the report!

If I don't use nil then everything works fine.

Currently, it's the best way to load missing resources. For some reason, it's important to load resources in a particular order returned by collectionproxy.missing_resources. If you don't do that, then there is a little chance to get the reported error.

In fact, I've got the error only once in our projects and then I wasn't able to trace the problem again.

I think that we should make an issue in the Defold repo.

aglitchman added a commit that referenced this issue Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants