br & date fixes, related events #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
self-closed br tags to help with github markup validation, line breaks to help some editing, remove unnecessary br markup (please use styling to add more space if needed), speaker h-cards (for when they're figured out), fixed various former 2019 dates copy/pastes and incorrect June 25-27 dates, re-added related events including HWC PDX the week of since we already have an event link for it!
aaronpk
requested changes
Feb 20, 2020
templates/summit/schedule.php
Outdated
| <div class="speaker"> | ||
| <a href="https://tantek.com/"><img src="/images/tantek.jpg"></a> | ||
| <p class="name">Tantek<br> Çelik</p> | ||
| <div class="speaker h-card"> |
There was a problem hiding this comment.
What's the purpose of adding an h-card here? is there a consuming use case? I would rather not have random microformats on the page if there isn't a plan to consume it from something, since it may confuse things like post type discovery.
There was a problem hiding this comment.
tl;dr: Dropped speaker h-cards pending further discussion. The consuming use-case is to be able to more quickly/easily add keynote speakers to your address book, however that's orthogonal from the rest of the fixes, so dropping h-card pending further discussion/consensus.
drop hcard added to keynote speakers, needs more discussion
aaronpk
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self-closed br tags to help with github markup validation, line breaks to help some editing, remove unnecessary br markup (please use styling to add more space if needed), speaker h-cards (for when they're figured out), fixed various former 2019 dates copy/pastes and incorrect June 25-27 dates, re-added related events including HWC PDX the week of since we already have an event link for it!