Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display logo & suppress photo notice on logo #86

Merged
merged 1 commit into from
May 2, 2020

Conversation

Lewiscowles1986
Copy link
Contributor

Had a chat about this last night on Indieweb chat. Just finished updating my site as a test-candidate.

As a user who is deliberately opting not to display a photograph of myself, who would rather be represented by a graphic than a photograph, in the absence of avatar support. I would like to see my logo displayed via indiewebify.me, and have the helpful message to include a photo suppressed, if I supply a logo, but not a photo; so that I'm not bothered by the message and do not feel friction with the choice to represent myself in this way.

Had a chat about this last night on Indieweb chat. Just finished updating my site as a test-candidate.

As a user who is deliberately opting not to display a photograph of myself, who would rather be represented by a graphic than a photograph, in the absence of avatar support. I would like to see my logo displayed via indiewebify.me, and have the helpful message to include a photo suppressed, if I supply a logo, but not a photo; so that I'm not bothered by the message and do not feel friction with the choice to represent myself in this way.
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a very reasonable minimal change, agreed with the reasoning and we should also update the text docs / suggestions accordingly (which can happen in a separate PR).

@tantek tantek merged commit d8f3edb into indieweb:master May 2, 2020
@Lewiscowles1986
Copy link
Contributor Author

If you can point me to where they are I'm happy to make the update and sorry that I did not already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants