Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

join_with_and support serial comma #27

Merged
merged 1 commit into from
Mar 22, 2024
Merged

join_with_and support serial comma #27

merged 1 commit into from
Mar 22, 2024

Conversation

tantek
Copy link
Member

@tantek tantek commented Mar 22, 2024

fixed join_with_and to handle both two item array ' and ', and more than item array with a serial (Oxford) comma

@tantek
join_with_and support serial comma
ac5890d 
fixed join_with_and to handle both two item array ' and ', and more than item array with a serial (Oxford) comma
capjamesg
capjamesg approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@capjamesg capjamesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Indeed, the Oxford comma is critical.

@aaronpk aaronpk merged commit 0741a33 into main Mar 22, 2024
1 check passed
@aaronpk aaronpk deleted the tantek-patch-1 branch March 22, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capjamesg capjamesg capjamesg approved these changes

@aaronpk aaronpk Awaiting requested review from aaronpk

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tantek @capjamesg @aaronpk