Ticket Endpoint #212
Ticket Endpoint #212
Conversation
|
@pfefferle Can you have a look at this? |
| @@ -31,7 +31,7 @@ public function indieauth_allow_localhost( $r, $url ) { | |||
| public function log_rest_api_errors( $result, $server, $request ) { | |||
| $request_route = $request->get_route(); | |||
| $result_route = $result->get_matched_route(); | |||
| $routes = array( 'indieauth/1.0/auth', '/indieauth/1.0/token' ); | |||
| $routes = array( 'indieauth/1.0/auth', '/indieauth/1.0/token', 'indieauth/1.0/ticket' ); | |||
There was a problem hiding this comment.
Won't be a showstopper, but this feels like it may be getting primed for a dedicated method for retrieving routes. Could also potentially get a filter for 3rd party integration.
There was a problem hiding this comment.
Good point. This was written a long time ago. I should have it retrieve all indieauth namespace routes.
There was a problem hiding this comment.
I'll likely save the idea for a future PR though.
|
Nothing notable standing out to me with this one, code wise. Feels all like pretty well known HTTP process and workflow which is good. |
Great, appreciate the help. It's still an experimental spec, but I'd like to merge it in so I can iterate on it. |
This merge implements an experimental ticket endpoint to receive tickets. It adds a UI to revoke or verify those tickets. The endpoint is disabled by default and only enabled with a wp-config flag.