New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Version 2.0 of Micropub plugin #150
Comments
A couple reports from my testing. 1. When reposting from monocle or together, the following php notices occur: [14-Aug-2018 16:46:50 UTC] Micropub Input: {"type":["h-entry"],"properties":{"repost-of":["https://jackjamieson.net/511-2/"]}} 14-Aug-2018 16:12:27 UTC] PHP Notice: Undefined index: content in/...{path}.../wp-content/plugins/wordpress-micropub-master/includes/class-micropub-endpoint.php on line 616 [14-Aug-2018 16:12:27 UTC] PHP Notice: Undefined index: summary in/...{path}.../wp-content/plugins/wordpress-micropub-master/includes/class-micropub-endpoint.php on line 622 [14-Aug-2018 16:12:27 UTC] PHP Notice: Undefined index: content in/...{path}.../wp-content/plugins/wordpress-micropub-master/includes/class-micropub-render.php on line 79 A repost is created, but it only consists of a link to the post. The content of the repost is otherwise empty. I don't know if I've ever micropubbed a repost before so I'm not sure if this is the expected behaviour. 2. Posting from Quill with attached image [14-Aug-2018 16:55:14 UTC] REST request: /micropub/1.0/media: {"q":"last"} [14-Aug-2018 16:55:14 UTC] REST result: : {"code":"rest_no_route","message":"No route was found matching the URL and request method","data":{"status":404}} |
Re 2 above, https://indieweb.org/micropub_media_endpoint#Query_the_last_thing_uploaded - Basically, only Quill supports querying an endpoint. But right now, it generates an error because the endpoint doesn't support querying. I will change it and allow it to be queried, but it will return a proper error at this point, as not supporting last in this round. |
FWIW I’m on master of all of the plugins & I cant log in with Quill or Indigenous |
@miklb Can I work with you to troubleshoot? What data do you have to reproduce? |
I’ll pull the logs & error messages & post here. |
Thanks, I want to narrow it down. Are you using the IndieAuth plugin or is it disabled? Does changing that make a difference? |
@jackjamieson2 If the client doesn't send the original post as content, the endpoint won't retrieve it, so that repost is technically correct. |
I updated all plugins to master. Should I be testing a branch? |
No, but there is one little IndieAuth fix, but your site URL is the same as your home url? |
Indigenous
and Quill just did a weird redirect loop to this |
So, missing access token suggests server filtering of the header |
But that url is missing wp login.php |
To my knowledge, I haven't changed any header settings in nginx in a long time, and was able to authenticate not that long ago. I've lost track honestly of when things last fully worked together though. |
I wonder what it could be. |
Is this working without the IndieAuth plugin? |
I haven't tested that, I thought the idea of refactoring the micropub plugin was better compatibility with WP IndieAuth. I'll try and test with IndieAuth off later this evening. |
Process of elimination |
A lot of things I’m thinking about eliminating these days…
…On Aug 16, 2018, 18:23 -0400, David Shanske ***@***.***>, wrote:
Process of elimination
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I am sorry |
I don’t hold you responsible David for my website woes. |
@dshanske you should still have a login to the indiewp.com on my server if you want to test my server configuration/mulit-site. Let me know if you need me to resend or activate/install anything. There is a plugin to view debug log from the admin too. |
@jackjamieson2 The latest merge should fix the PHP notices. |
As of this comment, per my conversation with @snarfed. I'm freezing any further enhancements. Only fixes and tests will be pushed until we release a version. While I'd like it if 100% of people had no issues, some are due to server issues and such, which I am always chasing as a priority to troubleshoot. I probably should settle for it working for the same or more people as it did before all these pushes and continue trying to figure out the remaining people's issues afterward. |
Can you document “server issues” that can cause the plugins to fail? |
Some observations from a fresh install running current IW Stack, but with the test Micropub install: Using micropublish.net to send a note gives the following error: followed by: I was able to log into IndieBookClub.biz and post there, but post didn't micropub to appear on my site. (This is likely a header stripping issue I'd seen with my production server, but isn't fixed on this install. I'll see what happens when I run things on my production site shortly.) Quill note post with photo worked (and showed up as photo kind). Bookmark post from quill gave 404 Page Not Found and redirected to https://quill.p3k.io/null on Teacup worked and set the right post kind, but put all content into the_content instead of into the properties fields I would have expected for Post Kinds. I could have sworn someone said Teacup had a media endpoint if it detected the site had one available, but I never saw a way to upload photos for the media endpoint in Teacup. While most of this may not seem perfect, it seems solid enough to me that I'll install the test version on production and rerun several of the tests including for OYS which I've got set up pthere and a couple of others. Given a few bumps my test server surely has, I suspect some of the issues I've seen will wash themselves out. |
@miklb Trying to. |
I just tried installing indieauth and micropub on a new wordpress from master. I was able to get an access token, and I tried posting from the command line:
if I remove the authorization header, it fails in the same way. If there is no authorization header, or if the access token is not valid, it should return an error before trying to check for scopes. |
Micropub errors for OYS 8-25-18 (using master branch from 2018-08-24 ef76125) (Originally published at https://boffosocko.com/2018/08/25/reply-to-release-version-2-0-of-micropub-plugin-%c2%b7-issue-150-%c2%b7-snarfed-wordpress-micropub/) |
Installed tree ef76125 from this repo, updated WP Indieauth to 3.1.5, logged into Quill to post a Note, received a 403 error when clicking on Post button. Error log produces the following: It shows the REST request I made from Quill with everything I filled out and ends with Similar to @chrisaldrich above |
for complete reporting I am seeing this from Omnibear
|
With the most recent version 261c782 I'm still getting errors posting with OwnYourSwarm: Is this indicating it isn't finding the correct user account?
|
I asked in IRC/chat but my curiosity about the error message regarding |
my latest debug.log for the error
|
@chrisaldrich is your site a stand alone WP install or a network install? |
@miklb That one is from a simple instance on a shared server. |
I am trying to figure out that error notice in the rest server. |
The invalid argument foreach is coming from a line in the REST server that sends headers. https://github.com/WordPress/WordPress/blob/master/wp-includes/rest-api/class-wp-rest-server.php#1269 (In the older versions 1259). It is called earlier as part of serve_request. I'm still stumped. The only possible thing I can think of that might explain this is the debug handling class. I'm curious if the error goes away if WP_DEBUG is false. But, that's the only thing in IndieAuth or Micropub that modifies the response coming back in |
Testing this version, installed via .zip download of master branch. These are my installed plugins, if it's helpful: | akismet | active | none | 4.0.8 | A simple note post from Quill posted successfully after the update. |
When I Refresh Configuration from Indigenous for Android, I get the following errors:
Indigenous was previously configured OK, but I'll just doublecheck and revert to previous WP Micropub to confirm what happens. UPDATE: Refresh Configuration is fine with v1.4.3 of WP Micropub plugin. |
I use Indigenous for Android. @swentel Thoughts? |
@ngm By the way, Webmention for Comments was merged into Webmentions |
@dshanske difference in endpoints maybe? I vaguely kind of remember seeing something like ?endpoint=micropub vs /micropub/1.0/endpoint (or something alike) If that's the case, Indigenous doesn't refresh endpoints yet :/ So you'll have to delete the account and add it again to get the new endpoints. |
That would be it. |
I'll prioritize IndiePass/indiepass-android#94 :) |
On 2.0, when I syndicate my posts to Mastodon (via all micropub clients that I've tried), the content is wrapped in (Noting that it's very possible that it's a problem with my theme or my syndication target code, but any pointers as to why it's not happening in 1.4.3?) |
It's a Post Kinds issue I need to push to stable. It doesn't know where to disable that extra code because of the Micropub changes. |
I fear I will never get enough data on issues regarding auth |
indieweb/wordpress-indieauth#113 - Auth issue @asuh reported has been resolved. Documentation to address in various plugins. The Micropub auth, which maps URL to author and is enabled when the IndieAuth plugin isn't active, would suffer the same issue. |
As @dshanske reported above, issue is resolved. My problem had to do with using Considering my site forces |
Being as many of the issues seem to be with an Indieauth plugin Micropub interaction and I think I fixed another Indieauth issue, want to retest this. |
I think, with 3.1.9 of Indieauth, we may be ready to release. |
Released. |
Version 2.0 is merely the name I'm using for all the changes thus far. Since I have decided I'm not going to pursue any further enhancements before releasing a new version, using this issue to track anything left to do before releasing this version as stable.
Asked @chrisaldrich , @jgmac1106, and @dougbeal if they would mind testing the current stable version for issues, as my tests with various Micropub clients seem to be working. Tests conducted with and without the IndieAuth plugin activated.
Tests should include posting with at least a client or two. Quill, Micropublish, etc.
Subject to that and any other blockers, want to share this with the world.
The text was updated successfully, but these errors were encountered: