-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed fan support #12
base: master
Are you sure you want to change the base?
Conversation
This was only impacting the below log message but it fixes some confusion.
Only obvious way in Ecobee API to do this, needs to submit current hot and cold setpoints as a hold but with fan=on
Added action for fan support plus an explicit log message when unimplemented calls are made instead of quietly swallowing these.
Enum used for mode translation and capture the MinOnTime published to device state
Publish the fanMinOnTime as device state, this should be made writable.
I'll have to defer to @rapamatic for testing with an Ecobee Smart. |
I can try to take a look at it this week with my smart... I don't do a lot of control of the fan settings - I just leave them in X minutes per hour mode, but I can test this |
Just doing some quick remote testing, it correctly shows fan status (is this new? I don't know) but I'm not able to change fan status, either on my older Smart or my newer 3.... I can do more detailed testing tonight - somewhat limited in what I can do from work. |
Scratch the above comments - I hadn't downloaded the correct version of the plugin! One suggestion would be to add the fanMinOnTime custom state to ecobee smart devices also - they have that capability. Fan status was correctly reported for my ecobee 3 and my smarts. However, I had issues changing fan status... specifically, going from auto (my default state) to fan on also set a hold temperature. I was able to go from a forced fan on state back to auto (essentially sending the resume schedule command). Here's my log entries:
|
Looking through the API specs, I think we can send a fan only hold:
The link here has info on how to structure the query with those parameters, something like this:
But you do need to send at least some dummy value for the hold temps... |
That does look more promising, I wonder if that will have the desired simple 'Fan is on' indication on the thermostat display as well instead of the current hold with fan and temps. I'll be anxious to try that approach, can check it this weekend. |
That works, adding the 'isTemperatureRelative' and 'isTemperatureAbsolute' params gives it the preferred behavior of just turning the fan on without the setpoint hold. I'll update the method call to just use that. I'll commit that change plus adding the MinOnTime to the smart series t-stat. Not incidentally - Using the 'web inspector' debugger in my web browser while using Ecobee's web app shows that same syntax. I should have thought of that sooner but it does give an additional validation that we're not making an unsupported API call .. it's just a badly documented one. |
Looks like someone else on the indigo forums is interested in this feature too, so good timing to be working on it. I'd be happy to test any changes you may have made, so we can get this update pushed out. |
From the original project - Fan hold support
In particular to @jdhorne and @rapamatic - Pls check these for sanity. I haven't checked to see whether I can merge them in on my own.
These changes create a new action to set the fan hold and rely on the existing 'resume' action to return to normal.
Works well for Ecobee3, I don't have an earlier 'Smart' unit to test on.