Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indi_sv305_ccd: Last line has garbage data #654

Closed
jctk opened this issue Sep 17, 2022 · 3 comments
Closed

indi_sv305_ccd: Last line has garbage data #654

jctk opened this issue Sep 17, 2022 · 3 comments
Assignees
@thx8411
Labels
bug Something isn't working

Comments

@jctk
Copy link
Contributor

jctk commented Sep 17, 2022 •
edited

Describe the bug
When Frame mode is set to RAW8 or Y8 in indi_sv305_ccd, the last line of data after shooting is garbage data.

To Reproduce

  1. Run driver
  2. Set the Frame mode to RAW8 or Y8.
  3. When taken, the last line of data is random patterns.

Expected behavior
The last line contains the image data taken.

Screenshots
Arrows point to destination line:
image

Desktop (please complete the following information):

  • INDI on OS: StellarMate OS
  • Client KStars on OS: Windows 11
  • INDI Version 1.9.7

Log Files
log_21-29-12.txt
@jctk jctk added the bug Something isn't working label Sep 17, 2022
@jctk
Copy link
Contributor Author

jctk commented Sep 17, 2022 •
edited

Hi, @knro and @thx8411
I will probably investigate when I have time.

@jctk
Copy link
Contributor Author

jctk commented Sep 18, 2022

Additional evidence.
Reproduces even in Frame Format RAW16
image

@jctk jctk changed the title indi_sv305_ccd: Last line has garbage data when Frame mode is RAW8 and Y8 indi_sv305_ccd: Last line has garbage data Sep 18, 2022
@jctk
Copy link
Contributor Author

jctk commented Sep 18, 2022 •
edited

Problem Cause

After setting the ROI with SVBSetROIFormat, the actual ROI must be obtained with SVBGetROIFormat.
The ROI obtained with SVBGetROIFormat may differ from the value specified with SVBSetROIFormat.

In sv305_ccd.cpp, the process to get the ROI actually set by SVBGetROIFormat is not implemented.

See also

SVBDemo.cpp's part on setting ROI.

jctk added a commit to jctk/indi-3rdparty-jctk that referenced this issue Sep 19, 2022
@jctk
BUGFIX: indi_sv305_ccd: garbage data in last line indilib#654
b29378e 
- In sv305_ccd.cpp, I implemented a process to get the ROI actually set by SVBGetROIFormat.
- After setting the ROI with SVBSetROIFormat, I need to get the actual ROI with SVBGetROIFormat, because the ROI obtained with SVBGetROIFormat may differ from the value specified with SVBSetROIFormat.
@jctk jctk mentioned this issue Sep 19, 2022
Merged
knro pushed a commit that referenced this issue Sep 19, 2022
@jctk
BUGFIX: indi_sv305_ccd: garbage data in last line (Issue #654) (#658)
54b02a5
@jctk jctk closed this as completed Sep 19, 2022
knro pushed a commit that referenced this issue Sep 20, 2022
@jctk @knro
BUGFIX: indi_sv305_ccd: garbage data in last line (Issue #654) (#658)
2a74a98
@jctk jctk mentioned this issue Oct 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thx8411 thx8411

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thx8411 @jctk