Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Driver for Esatto with Arco (goto, abort, sync, cal) #1634

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Add Driver for Esatto with Arco (goto, abort, sync, cal) #1634

merged 2 commits into from
Mar 3, 2022

Conversation

ChristianHen
Copy link
Contributor

Add new Driver for Esatto-Arco unit based on the existing Esatto / Sestosenso-Driver

@knro
Copy link
Contributor

knro commented Mar 3, 2022

Thanks, I think you should move this to rotator directly unless it's BOTH a focuser + rotator? Isn't this for the Arco 2" and 3" ?

@ChristianHen
Copy link
Contributor Author

ChristianHen commented Mar 3, 2022 via email

@knro
Copy link
Contributor

knro commented Mar 3, 2022

Please check CI build failure. Also, where all functionalities tested? everything in the INDI control panel is confirmed to function correctly?

@ChristianHen
Copy link
Contributor Author

I changed one line in the .cpp ( if(!busy==0) --> if(!(busy==0) ) then the MacOs Workflow ran successfully in my repo.

PyIndi and Docker failed. Docker-Workflow claims that the repo-name must be lower case. I dont' know what to do about these two workflows.

@ChristianHen
Copy link
Contributor Author

I created a second github-account with a username that is completely lower case. There the docker-workflow runs successfully.
So dokker, macOS and Linux are ok.

@knro
Copy link
Contributor

knro commented Mar 3, 2022

I see that Arco can be used separately... so this driver required a combination of Essato + Arco together I presume?

@ChristianHen
Copy link
Contributor Author

ChristianHen commented Mar 3, 2022 via email

@knro
Copy link
Contributor

knro commented Mar 3, 2022

Really.. okay thanks for clarifying this.. so Arco can never be used standalone??

@ChristianHen
Copy link
Contributor Author

ChristianHen commented Mar 3, 2022 via email

@knro knro merged commit 5404ea4 into indilib:master Mar 3, 2022
@spacekitteh
Copy link
Contributor

Really.. okay thanks for clarifying this.. so Arco can never be used standalone??

Yeah, it's extreme vendor lock-in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants