Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New temp file name for each status check, /usr/shared/indi/scripts us… #7

Merged
merged 1 commit into from
May 29, 2016
Merged

Conversation

polakovic
Copy link
Contributor

…ed for linux

@@ -28,7 +28,6 @@
#include "telescope_script.h"

#define POLLMS 1000
#define STATUS_FILE "/tmp/indi-telesope-gateway.status"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that be better somewhere in the /var/run? This is essentially a communication point, isn't it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about INDI FIFO? I often create it in /tmp, would it better in /var/run ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand both locations are OK. But /var/run tends to be used more recently. It is often in memory and non-persistant.

@knro
Copy link
Contributor

knro commented May 29, 2016

I am very aware it is against Debian guidelines. But users who install INDI stuff in /usr/local always end up in conflict with what is installed in /usr, and they often forget the installation in /usr/local at some point.

@jochym
Copy link
Contributor

jochym commented May 29, 2016

You obviously have more experience with this. But right now we are not hardcoding the path to the installation. Making it os-dependent adds to the confusion IMHO. Maybe we should use the installation location instead ?

@knro
Copy link
Contributor

knro commented May 29, 2016

Let me merge this as I have immediate pending fixes as well

@knro knro closed this May 29, 2016
@knro knro reopened this May 29, 2016
@knro knro merged commit aaa7933 into indilib:master May 29, 2016
@polakovic
Copy link
Contributor Author

Installation location can't be used for anything, what can be modified on OSX, whole bundle is digitally signed.

@knro
Copy link
Contributor

knro commented May 29, 2016

Use of tmpnam(NULL) is generating a gcc warning "Use of tmpnam is dangerous", is there a better solution?

@jochym
Copy link
Contributor

jochym commented May 29, 2016

Ok. So maybe it was good idea by @polakovic to have user-supplied scripts in /usr/local... Maybe we have grown large enough to have some config in /etc ?

@knro
Copy link
Contributor

knro commented May 29, 2016

Config already stored under ~/.indi

@polakovic
Copy link
Contributor Author

Use of tmpnam is dangerous, but in this case it is under control :) ~/.indi is an option, but I have a feeling, that in this case it is systemwide and not personal setting.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants