-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New temp file name for each status check, /usr/shared/indi/scripts us… #7
Conversation
@@ -28,7 +28,6 @@ | |||
#include "telescope_script.h" | |||
|
|||
#define POLLMS 1000 | |||
#define STATUS_FILE "/tmp/indi-telesope-gateway.status" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't that be better somewhere in the /var/run? This is essentially a communication point, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about INDI FIFO? I often create it in /tmp, would it better in /var/run ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand both locations are OK. But /var/run tends to be used more recently. It is often in memory and non-persistant.
I am very aware it is against Debian guidelines. But users who install INDI stuff in /usr/local always end up in conflict with what is installed in /usr, and they often forget the installation in /usr/local at some point. |
You obviously have more experience with this. But right now we are not hardcoding the path to the installation. Making it os-dependent adds to the confusion IMHO. Maybe we should use the installation location instead ? |
Let me merge this as I have immediate pending fixes as well |
Installation location can't be used for anything, what can be modified on OSX, whole bundle is digitally signed. |
Use of tmpnam(NULL) is generating a gcc warning "Use of tmpnam is dangerous", is there a better solution? |
Ok. So maybe it was good idea by @polakovic to have user-supplied scripts in /usr/local... Maybe we have grown large enough to have some config in /etc ? |
Config already stored under ~/.indi |
Use of tmpnam is dangerous, but in this case it is under control :) ~/.indi is an option, but I have a feeling, that in this case it is systemwide and not personal setting. |
…ed for linux