[WIP] Update Transaction trait and implementations to return counts #199
Conversation
update Transaction trait so it returns counts from set and delete operations.
Update MemoryDatastore so it returns counts from set and delete operations.
|
@ysimonson Can you review the changes I made to |
|
|
||
| let mut deletable_vertex_properties: Vec<(Uuid, String)> = Vec::new(); | ||
| let mut deletable_vertex_properties: Vec<(Uuid, String)> = Vec::new(); |
| } | ||
|
|
||
| let mut deletable_edges: Vec<EdgeKey> = Vec::new(); | ||
| self.vertex_properties.remove(&property_key); |
There was a problem hiding this comment.
This is iterating through self.vertex_properties and removing elements at the same time, which should fail AFAIK
|
You can test out these changes by cding into lib and running |
|
@ozgrakkurt how's progress on this? I'm wondering if I should wait for this before releasing 3.0. |
I hope I can finish it by the end of the week. |
|
I'm going to close this out since there hasn't been progress in the past few months. Hoping you can circle back to this at some point though @ozgrakkurt! |
Update Transaction trait and implementations to return counts from set and delete operations for checking if operation succeeded.
closes #192