Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cocoa pods support #19

Closed
wants to merge 7 commits into from
Closed

Feature/cocoa pods support #19

wants to merge 7 commits into from

Conversation

krodak
Copy link

@krodak krodak commented Jan 6, 2016

I prepared full support of CocoaPods - the support is added on 2 levels:

  • CocoaMarkdown itself uses CocoaPods to maintain its dependencies instead of using git submodules or adding subprojects. This is most common way of adding 3rd party libs to Cocoa projects now.
    I chose to add Pods code to the repository - why? Because CM is used mostly as library, it should be usable even if 3rd party components will change location / become unsupported.
  • CocoaMarkdown can be used via CocoaPods - I added .podspec pointing to the original repo, so it will work after accepting this PR - the latest commit takes care of this.

Finally, I've corrected minor issues in example projects so they are compatible with XCode 7 and Swift 2.X

@indragiek
Copy link
Owner

@krodak Thank you for this pull request! Adding a podspec for this project is great, but I would like to keep CocoaMarkdown itself using git submodules instead of CocoaPods. Some people will want to integrate the library directly into their Xcode project without using a package manager, and others will want to use other package managers like Carthage and Swift Package Manager (if it eventually supports Objective-C modules). For this reason, it would be preferable if CocoaMarkdown didn't have a build dependency on CocoaPods.

@pronebird pronebird mentioned this pull request Jan 28, 2016
@indragiek
Copy link
Owner

Podspec was added in #20.

@indragiek indragiek closed this Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants