Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor functionality from the GrounderInstance class into the Grounder class #16

Merged
merged 5 commits into from
Mar 17, 2020
Merged

Refactor functionality from the GrounderInstance class into the Grounder class #16

merged 5 commits into from
Mar 17, 2020

Commits on Mar 17, 2020

  1. Refactor functionality from GrounderInstance class to Grounder class 

    The only functionality I can see for the GrounderInstance is to make the instance of the grounder lazy. Therefore, I moved some of the functionality from this class directly into the Grounder class
    @cthoyt @bgyori
    cthoyt authored and bgyori committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    6e70aed View commit details
    Browse the repository at this point in the history

  2. Update formatting 

    [skip ci]
    @cthoyt @bgyori
    cthoyt authored and bgyori committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    15994cd View commit details
    Browse the repository at this point in the history

  3. Refactor get_names function as well

    @cthoyt @bgyori
    cthoyt authored and bgyori committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    3aab21e View commit details
    Browse the repository at this point in the history

  4. Remove sort argument and add some comments

    @bgyori
    bgyori committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    12fc541 View commit details
    Browse the repository at this point in the history

  5. Remove sort argument in API

    @bgyori
    bgyori committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    2708919 View commit details
    Browse the repository at this point in the history