Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate c{double, float}_fma for pyopencl #698

Merged
merged 7 commits into from
Dec 27, 2022
Merged

Generate c{double, float}_fma for pyopencl #698

merged 7 commits into from
Dec 27, 2022

Conversation

isuruf
Copy link
Collaborator

@isuruf isuruf commented Nov 2, 2022

@isuruf isuruf changed the title Generate c{double, float}_muladd for pyopencl Generate c{double, float}_fma for pyopencl Nov 3, 2022
inducer
inducer reviewed Nov 4, 2022
View reviewed changes
Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The code itself is fine, but I think it raises two "bigger-picture" questions.

loopy/target/pyopencl.py Show resolved Hide resolved
loopy/target/pyopencl.py Show resolved Hide resolved
@inducer
Copy link
Owner

inducer commented Nov 8, 2022 •
edited
Loading

As discussed: Introduce a flag allow_fp_reordering, gate this rewrite on that, also gate the binary-tree-pow, add a note that some FP reordering may still take place. (#700)

@inducer inducer mentioned this pull request Nov 8, 2022
Open
@isuruf isuruf force-pushed the muladd branch 3 times, most recently from 1c8e794 to 9eaac97 Compare November 20, 2022 19:05
@isuruf
Copy link
Collaborator Author

isuruf commented Nov 20, 2022

I guess we need a new PyOpenCL version

@inducer
Copy link
Owner

inducer commented Nov 21, 2022

https://pypi.org/project/pyopencl/2022.3/

@inducer
Copy link
Owner

inducer commented Nov 21, 2022

There seem to be some pytato tests that are now unhappy.

@isuruf
Copy link
Collaborator Author

isuruf commented Nov 21, 2022

Yes, they are using the pyopencl from conda. Will wait for the bot to open a PR to conda-forge.

@isuruf isuruf requested a review from inducer November 23, 2022 17:53
inducer
inducer reviewed Dec 27, 2022
View reviewed changes
loopy/target/c/codegen/expression.py Outdated Show resolved Hide resolved
loopy/target/pyopencl.py Outdated Show resolved Hide resolved
loopy/target/pyopencl.py Outdated Show resolved Hide resolved
loopy/target/pyopencl.py Show resolved Hide resolved
loopy/options.py Outdated Show resolved Hide resolved
@inducer
Copy link
Owner

inducer commented Dec 27, 2022

Rerunning post illinois-scicomp/machine-shop-maintenance@f4ecbd9 to address the Intel failure.

@inducer inducer merged commit 033cebd into inducer:main Dec 27, 2022
@inducer
Copy link
Owner

inducer commented Dec 27, 2022

Thanks!

@isuruf isuruf deleted the muladd branch December 28, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inducer inducer inducer left review comments

@kaushikcfd kaushikcfd kaushikcfd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isuruf @inducer @kaushikcfd