Flatten and unflatten by reshaping when possible #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
reviewed
Apr 9, 2021
meshmode/dof_array.py
Outdated
| # NOTE: arrays with one group are common enough and don't require any | ||
| # concatenation to "flatten", but can just be reshaped | ||
| if len(ary) == 1: | ||
| return list(ary)[0].reshape(-1) |
There was a problem hiding this comment.
To be safe, I think it'd be useful to verify the memory layout using the strides here.
There was a problem hiding this comment.
I wanted to do something like that, but wasn't sure how it would interfere with the lazy stuff. Would adding an actx.np.reshape and reusing this make more sense?
alexfikl
force-pushed
the
flattening-reshape
branch
from
5479495
to
9146e48
Compare
alexfikl
force-pushed
the
flattening-reshape
branch
from
1934be3
to
a235239
Compare
inducer
reviewed
Apr 13, 2021
meshmode/dof_array.py
Outdated
Comment on lines
501
to
509
| if len(ary) == 1: | ||
| ary0 = list(ary)[0] | ||
| if ary0.flags.c_contiguous: | ||
| return ary0.reshape(-1, order="C") | ||
| elif ary0.flags.f_contiguous: | ||
| return ary0.reshape(-1, order="F") | ||
| else: | ||
| # NOTE: array has unsupported strides, so we need to do a copy | ||
| pass |
There was a problem hiding this comment.
This isn't correct. The existing array can be reshaped if and only if the strides are (itemsize*nunit_dofs_per_element, itemsize). (Note that subclassing array contexts might do weird things like introduce extra dimensions.)
|
Unsubscribing... @-mention or request review once it's ready for a look or needs attention. |
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Merged
|
This has been graciously continued by @thomasgibson in #192. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this sort of what you hand in mind in inducer/pytential#71 (comment)?
It seems to do the trick, i.e.
flattenandunflattendon't show up anywhere near the top of any profiling (for a single group mesh at least).