Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to compute edges & faces from elements #3

Closed
wants to merge 1 commit into from

Conversation

goxberry
Copy link
Contributor

Add some utility methods to compute edge & face information from
subclasses of GmshElementBase.

Add:
- gmsh_edge_tuples method to all subclasses of GmshElementBase;
computes a tuple representation of all edges in an element
- gmsh_face_tuples method to all subclasses of GmshElementBase;
computes a tuple representation of all faces in an element
- get_gmsh_edge_indices method to GmshElementBase; maps tuple
representation of edges to node index representation of edges
- get_gmsh_face_indices method to GmshElementBase; maps tuple
representation of edges to node index representation of edges

Add some utility methods to compute edge & face information from
subclasses of GmshElementBase.

Add:
    - gmsh_edge_tuples method to all subclasses of GmshElementBase;
      computes a tuple representation of all edges in an element
    - gmsh_face_tuples method to all subclasses of GmshElementBase;
      computes a tuple representation of all faces in an element
    - get_gmsh_edge_indices method to GmshElementBase; maps tuple
      representation of edges to node index representation of edges
    - get_gmsh_face_indices method to GmshElementBase; maps tuple
      representation of edges to node index representation of edges
@goxberry
Copy link
Contributor Author

I ended up writing these utility functions as part of developing a subclass of GmshMeshReceiverBase that inserts cohesive elements into cracked Gmsh meshes. If an example of that would be interesting, I could contribute an implementation I'm currently working on.

@inducer
Copy link
Owner

inducer commented Aug 14, 2014

Thanks for taking the time to put together this pull request. I ultimately don't think that people will wind up using the meshpy classes as their internal mesh representation (or, at least, that's not their intended purpose). As such, I'm reluctant to add this code, which is a little separate from the purpose of the code surrounding it.

I agree that it's annoying that essentially every user will wind up writing a version of what you've written (I have!), but I don't know a really good solution to this problem...

Andreas

@inducer inducer closed this Aug 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants