improve KeyBuilder documentation #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasdiener
force-pushed
the
keyb-doc
branch
2 times, most recently
from
b50144c
to
09e72f9
Compare
matthiasdiener
force-pushed
the
keyb-doc
branch
3 times, most recently
from
da836f6
to
3d81f6e
Compare
matthiasdiener
force-pushed
the
keyb-doc
branch
from
3d81f6e
to
93103a5
Compare
matthiasdiener
commented
Mar 25, 2024
I don't know that it's worth the pain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: What do you think of renaming the class to
PersistentKeyBuilderorPersistentHashBuilder? We could keep the old name as an alias. This could clarify the goal of the KeyBuilder, as well as its connection toPersistentDict.Please squash