Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a bunch of unused pylint supressions #243

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

alexfikl
Copy link
Contributor

@alexfikl alexfikl commented Jul 6, 2024

This removes all the unused suppressions reported by --enable=I0021. I'm using pylint 3.2.5 on python 3.12.4, so I imagine not all of these will still pass on the CI, but hopefully some 😁

EDIT: That's weird.. I really didn't expect all those no-member ones to pass. Oh well!

@alexfikl alexfikl marked this pull request as ready for review July 6, 2024 07:08
@alexfikl
Copy link
Contributor Author

alexfikl commented Jul 6, 2024

So the pypy CI failed again in https://github.com/inducer/pytools/actions/runs/9817472729/job/27108879263?pr=243
It seems to be a known issue pytest-dev/pytest#11771

The issue seems to be fixed with pypy3.9 (at least one user said it was in the pytest issue), so this bumps the version for now..

@inducer inducer merged commit ba91e23 into inducer:main Jul 8, 2024
16 checks passed
@alexfikl alexfikl deleted the remove-unused-pylint branch July 8, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants