Add support for parsing dotted names into tags #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
reviewed
Dec 12, 2020
kaushikcfd
force-pushed
the
parse_tag
branch
2 times, most recently
from
44f0ead
to
c2f9057
Compare
- limit line columns length to 85 - install lark-parser for pylint,docs to resolve modules
inducer
reviewed
Jan 11, 2021
| @@ -7,7 +7,7 @@ Pytest: | |||
| # AK, 2020-12-13 | |||
| rm pytools/log.py | |||
|
|
|||
| export EXTRA_INSTALL="numpy" | |||
| export EXTRA_INSTALL="numpy lark-parser" | |||
There was a problem hiding this comment.
Could you push a sister MR to Gitlab (add the link to the PR description) to ensure that passes, too?
There was a problem hiding this comment.
inducer
reviewed
Jan 11, 2021
inducer
reviewed
Jan 11, 2021
pytools/tag.py
Outdated
Comment on lines
268
to
304
| TAG_GRAMMAR = """ | ||
| tag: tag_class "(" params ")" -> map_tag_from_python_class | ||
| | SHORTCUT -> map_tag_from_shortcut | ||
|
|
||
| params: -> map_empty_args_params | ||
| | args -> map_args_only_params | ||
| | kwargs -> map_kwargs_only_params | ||
| | args "," kwargs -> map_args_kwargs_params | ||
|
|
||
| ?kwargs: kwarg | ||
| | kwargs "," kwarg -> map_kwargs | ||
|
|
||
| args: arg -> map_singleton_args | ||
| | args "," arg -> map_args | ||
|
|
||
| kwarg: name "=" arg -> map_kwarg | ||
|
|
||
| ?arg: tag | ||
| | INT -> map_int | ||
| | ESCAPED_STRING -> map_string | ||
|
|
||
| tag_class: module "." name -> map_tag_class | ||
|
|
||
| module: name -> map_top_level_module | ||
| | module "." name -> map_nested_module | ||
|
|
||
| name: CNAME -> map_name | ||
| SHORTCUT: "." ("_"|LETTER) ("_"|LETTER|DIGIT|".")* | ||
|
|
||
| %import common.INT | ||
| %import common.ESCAPED_STRING | ||
| %import common.DIGIT | ||
| %import common.LETTER | ||
| %import common.CNAME | ||
| %import common.WS | ||
| %ignore WS | ||
| """ |
There was a problem hiding this comment.
Looked over the grammar, looks OK. (Please leave this for me to resolve at final review.)
3 tasks
|
Probably I should rewrite this as |
|
Unsubscribing... @-mention or request review once it's ready for a look or needs attention. |
I actually don't think so. We'll be able to reuse this as we use more lark. Sorry I've been slow to review. Otherwise ready for another look from your end? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.