[slideshow] fix id length validation

indutny · Jul 2, 2011 · 5bc2cfa · 5bc2cfa
1 parent 1e7c532
commit 5bc2cfa
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/slides/slideshow.js b/lib/slides/slideshow.js
@@ -46,15 +46,15 @@ slideshow.init = function(Slideshow, Slide, server) {
   // Add get static method
   Slideshow.static({
     get: function(req, res, callback) {
-
       if (!req.params.slideshow) return res.json(404);
 
-      var Slideshow = mongoose.model('Slideshow');
+      var Slideshow = mongoose.model('Slideshow'),
+          validId = req.params.slideshow.length <= 12;
 
       if (!callback && typeof res === 'function') {
         callback = res;
 
-        if (req.params.slideshow <= 12) {
+        if (validId) {
           Slideshow.findById(req.params.slideshow);
         } else {
           onResult(null, null);
@@ -70,7 +70,7 @@ slideshow.init = function(Slideshow, Slide, server) {
         return;
       }
 
-      if (req.params.slideshow <= 12) {
+      if (validId) {
         Slideshow.findById(req.params.slideshow, onSecondResult);
       } else {
         onSecondResult(null, null);