Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TCP graceful shutdown in lifecycle interface. #719

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implement TCP graceful shutdown in lifecycle interface. #719

wants to merge 3 commits into from

Commits on Sep 9, 2021

  1. TemporarySharedPtr: Followed changes in omnet with class descriptor.

    @levy
    levy committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    c744b22 View commit details
    Browse the repository at this point in the history

  2. IApskModulation: Fixed field types to be the same as in the existing … 

    …C++ class.
    @levy
    levy committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    656bdb5 View commit details
    Browse the repository at this point in the history

  3. TODO TCP: Implemented graceful stop operation which closes all open c… 

    …onnections and waits for the close to be finished.

TelnetApp is modified to test this with shutdownrestart example, this modification is not needed

Open questions:
 - what happens with the callback to the application (which is already stopped) when
the socket is closed? Currently it causes an error.
 - TCP starts a very long timeout (120s) after receiving the FIN bit, so the connection to be removed takes a lot of time
    @levy
    levy committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    b99e465 View commit details
    Browse the repository at this point in the history