Implement TCP graceful shutdown in lifecycle interface. #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnections and waits for the close to be finished. TelnetApp is modified to test this with shutdownrestart example, this modification is not needed Open questions: - what happens with the callback to the application (which is already stopped) when the socket is closed? Currently it causes an error. - TCP starts a very long timeout (120s) after receiving the FIN bit, so the connection to be removed takes a lot of time
adamgeorge309
force-pushed
the
master
branch
from
e712099
to
6b2763f
Compare
levy
force-pushed
the
master
branch
2 times, most recently
from
b4106be
to
59bbb86
Compare
levy
force-pushed
the
master
branch
4 times, most recently
from
e4fdb4a
to
4f97fe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was created during the 2021 summit. It's incomplete, see the comments.