Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Make IPRange.less sort subset ranges after their superset. #176

Merged
merged 1 commit into from
May 21, 2021

Conversation

danderson
Copy link
Member

This doesn't alter the behavior of dependent code, but does
make the sort order slightly more "natural" and consistent.

Fixes #145.

Signed-off-by: David Anderson dave@natulte.net

@danderson danderson requested a review from josharian May 21, 2021 02:30
Copy link
Collaborator

@josharian josharian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two unrelated documentation nits, if you're game.

netaddr.go Outdated Show resolved Hide resolved
netaddr.go Outdated Show resolved Hide resolved
This doesn't alter the behavior of dependent code, but does
make the sort order slightly more "natural" and consistent.

Fixes #145.

Signed-off-by: David Anderson <dave@natulte.net>
@danderson danderson merged commit f0b6b1e into main May 21, 2021
@danderson danderson deleted the danderson/bug-145 branch May 21, 2021 03:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPRange sort order is inconsistent with coverage (superset/subset)
2 participants