Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify descriptor builder to allow for multiple images to be passed into the builder pattern. #285

Open
Tracked by #533
IAmNotHanni opened this issue Dec 28, 2020 · 0 comments
Assignees
Labels
cat:refactor refactor/clean up/simplifications/etc.

Comments

@IAmNotHanni
Copy link
Member

Currently, the builder pattern allows only one element to be passed into it at a time:

m_descriptors.emplace_back(
        builder.add_uniform_buffer<ModelMatrixUBO>(m_uniform_buffers[0].buffer(), 0, VK_SHADER_STAGE_VERTEX_BIT)
            .build(model_descriptor_name));

Sometimes we need to insert an array of images.
Implement this!

@IAmNotHanni IAmNotHanni added the cat:enhancement enhancement/requested feature/update of existing features label Dec 28, 2020
@IAmNotHanni IAmNotHanni self-assigned this Dec 28, 2020
@IAmNotHanni IAmNotHanni added this to TODO in Vulkan-Renderer via automation Dec 28, 2020
IAmNotHanni added a commit that referenced this issue Dec 28, 2020
…ages to be passed into the builder pattern. Closes #285.

Signed-off-by: Johannes <johannesschneider@outlook.com>
@IAmNotHanni IAmNotHanni changed the title Modify descriptor build to allow for multiple images to be passed into the builder pattern. Modify descriptor builder to allow for multiple images to be passed into the builder pattern. Jan 5, 2021
@IAmNotHanni IAmNotHanni added cat:refactor refactor/clean up/simplifications/etc. and removed cat:enhancement enhancement/requested feature/update of existing features labels Mar 19, 2023
@IAmNotHanni IAmNotHanni mentioned this issue Jun 14, 2023
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:refactor refactor/clean up/simplifications/etc.
Projects
Development

No branches or pull requests

1 participant